[3.0] Fix EnumGroupRegression test case #2525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exanite
changed the title
…Regression test case This fixes the Constants_* and enums_* groups from being output for the OpenCL XML spec in the EnumGroupRegression test case. The change to cl_compiler_mode_altera is justifiable since it is an empty enum.
Exanite
force-pushed
the
fix/silktouch-enum-group-regression-test
branch
from
3dfc1fc to
5165d3c
Compare
github-project-automation
bot
moved this from Todo
to In Progress
in Silk.NET Development Tracker
github-project-automation
bot
moved this from In Progress
to Done
in Silk.NET Development Tracker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This prevents the
Constants_*andenums_*groups from being output for the OpenCL XML spec in the EnumGroupRegression test case. The change tocl_compiler_mode_alterais justifiable since it is an empty enum.Note that empty enums still contain important information, such as whether they are
[Flags]types or not.These notably affect the generation of the Vulkan bindings where ignoring these empty enums causes some enums to turn into non-Flags types.
Related issues, Discord discussions, or proposals
Discord discussion: https://discord.com/channels/521092042781229087/587346162802229298/1454577375063970045
Further Comments