Fix 24637 #9072

thewilsonator · 2024-10-27T08:09:42Z

merge stable

Remove std.conv import from quickSortImpl

…g#9019) * Move `std.math.exponential.pow` implementation outside template * Fix compilation on Mac

Caught with grep -Er '\(\$[A-Za-z]'

for link in $(grep -Eor 'https?://[^\\)", ]+' | grep -v dlang.org \ | grep -Eo 'https?://.+'); do (printf "%s: " "$link"; curl -Is "$link" \ | head -n1) | grep -E '4..$'; done for link in $(grep -Eor '\\$\\(HTTP .+, ' | grep -v dlang.org \ | cut -d' ' -f2- | sed 's/, .*$//'); do out="$(curl -Is "$link")"; \ (! [ $? = 0 ] || printf '%s' "$out" | head -n1 | grep -Eq '4..') \ && printf '%s\\n' "$link"; done

It's implemented in Windows but it's not part of standard C. https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/fdopen

replace dead links Signed-off-by: Vladimir Panteleev <[email protected]> Signed-off-by: Nicholas Wilson <[email protected]> Merged-on-behalf-of: Nicholas Wilson <[email protected]>

Co-authored-by: Dennis Korpel <[email protected]>

Note: www.canonware.com/download/jemalloc/jemalloc-latest/doc/jemalloc.html jemalloc link isn't responding, and it now lives at jemalloc.net (see also https://github.com/jemalloc/jemalloc?tab=readme-ov-file#readme). Fixes Bugzilla Issue 24667 - goo.gl is going away.

Bugzilla 23300 - add testcase for std.array on scope InputRange

@safe

…rs from files in @safe code (dlang#9030)

…ng#9032)

dlang#9036)

The second opCast overload is necessary to allow built-in implicit conversions (e.g., mutable to const) to be performed explicitly via a cast expression. Nullable.opEquals depends on this behavior.

…_t length' without using 'data' property Add `length` property rather than `app[].length`. Also remove `@trusted` attribute from `@safe` function.

* fix long line linter error * Update package.d

…of fields in JSON objects

Avoid breaking code that do "final switch" oven JSONType.

Fix Issue 24823 - std.json: Allow optionally preserving the order of fields in JSON objects

Added 'Haiku' and 'Solaris' to 'system'.

* Add documentation from the Phobos 3 Design repo. Add section on Template Reduction by request of Walter. Split up documents for clarity. * Add README.md. Update documents using documents from the V3 Design Repo. * Move numeric to the math package.

…pt. (dlang#9069) * Remove Phobos 3 dub.sdl and replace it with the build_v3.d buid script. * Add environment bang to the build script. * Fix the Phobos v3 build script so that unit tests work on POSIX. --------- Co-authored-by: Jonathan M Davis <[email protected]>

dlang-bot · 2024-10-27T08:09:46Z

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
I have provided a detailed rationale explaining my changes
New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	14138	major	std.parallelism.task breaks @safety
✓	15315	normal	can break immutable with std.algorithm.move
✓	20870	normal	std.outbuffer.printf is trusted
✓	20872	normal	std.array.assocArray trusts user-provided 'front' for values
✓	22293	enhancement	Nullable should define opCast!bool
✗	23300	normal	std.array : array wrongly propagates scopeness of source
✓	24667	normal	goo.gl is going away
✓	24685	major	std.stdio.File.rawRead allows reading raw pointers from files in @safe code
✓	24698	enhancement	Appender needs to expose readonly property 'size_t length' without using 'data' property

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#9072"

0-v-0 and others added 30 commits June 22, 2024 11:07

Remove std.conv import from quickSortImpl

d8e8f1f

Merge remote-tracking branch 'upstream/stable' into merge_stable

36992a3

Merge pull request dlang#9020 from ibuclaw/merge_stable

0c28620

merge stable

Merge pull request dlang#9017 from 0-v-0/master

0e17a64

Remove std.conv import from quickSortImpl

Move std.math.exponential.pow implementation outside template (dlan…

a6ad152

…g#9019) * Move `std.math.exponential.pow` implementation outside template * Fix compilation on Mac

fix ddoc blunders

f176df8

Caught with grep -Er '\(\$[A-Za-z]'

fix minor spelling mistake

581f473

std.stdio: fdopen is a POSIX library function

7c68568

It's implemented in Windows but it's not part of standard C. https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/fdopen

Merge pull request dlang#9023 from jtbx-patches/deadlinks

82b745d

replace dead links Signed-off-by: Vladimir Panteleev <[email protected]> Signed-off-by: Nicholas Wilson <[email protected]> Merged-on-behalf-of: Nicholas Wilson <[email protected]>

std.json: Document opEquals (dlang#8975)

d5780aa

Co-authored-by: Dennis Korpel <[email protected]>

Fix Lockstep attribute limitation

0a1735b

Address style errors

9a63e1c

Fix problems with reverse

4d5ba46

Address style errors

0050fb0

Bugzilla 23300 - add testcase for std.array on scope InputRange

2959a22

DEPRECATED_2.107 code removed (dlang#9028)

8a7aee0

Adds check bounds of year to std.datetime.date.Date

c00a5ee

Merge pull request dlang#9026 from dkorpel/std-array-testcase

6b529de

Bugzilla 23300 - add testcase for std.array on scope InputRange

Fix Bugzilla 24685 - std.stdio.File.rawRead allows reading raw pointe…

4d54884

…rs from files in @safe code (dlang#9030)

Fix Bugzilla 14138 - std.parallelism.task breaks @safety (dlang#9033)

7a14c89

Fix Bugzilla 15315 - can break immutable with std.algorithm.move (dla…

9ffe71f

…ng#9032)

Fix Bugzilla 20870 - std.outbuffer.printf is trusted (dlang#9037)

4552211

Fix Bugzilla 20872 - std.array.assocArray trusts user-provided 'front… (

4641576

dlang#9036)

Silence buildkite style failure on std.range

bdc034d

Fix Bugzilla 22293: opCast!bool for Nullable (dlang#9039)

ebd24da

The second opCast overload is necessary to allow built-in implicit conversions (e.g., mutable to const) to be performed explicitly via a cast expression. Nullable.opEquals depends on this behavior.

Remove std.conv import from skipData (dlang#9040)

5920001

Fix Bugzilla 24698 - Appender needs to expose readonly property 'size…

f11b19d

…_t length' without using 'data' property Add `length` property rather than `app[].length`. Also remove `@trusted` attribute from `@safe` function.

std.uni: Make auto ref adjacent

bbb1566

thewilsonator and others added 13 commits October 21, 2024 09:44

fix long line linter error (dlang#9060)

ab46287

* fix long line linter error * Update package.d

remove uses of classinfo, rebases part of dlang#7445 (dlang#9062)

fb602ef

remove classinfo uses, rebases part of dlang#7445 (dlang#9061)

44296a1

Fix Bugzilla 24823 - std.json: Allow optionally preserving the order …

dfb9db4

…of fields in JSON objects

Move ordered object indication into a new bool

800dd75

Avoid breaking code that do "final switch" oven JSONType.

Added Haiku and Solaris on OS enum and version

76a70ab

Added Haiku and Solaris on OS enum and version

00d56d0

Merge pull request dlang#9064 from CyberShadow/json-order

d447702

Fix Issue 24823 - std.json: Allow optionally preserving the order of fields in JSON objects

Merge pull request dlang#9066 from Cyrodwd/system-new-oses

1417cc5

Added 'Haiku' and 'Solaris' to 'system'.

overhaul documentation of std.string indexOf-like functions (dlang#8560)

54cfc22

Fix bugzilla issue 24637

4a0c257

thewilsonator requested review from CyberShadow, JackStouffer, MetaLang, PetarKirov, andralex, burner, dnadlinger, ibuclaw, jmdavis, kyllingstad, schveiguy and wilzbach as code owners October 27, 2024 08:09

dlang-bot added Severity:Bug Fix Severity:Enhancement labels Oct 27, 2024

LightBender closed this Oct 27, 2024

thewilsonator deleted the fix-24637 branch October 27, 2024 08:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix 24637 #9072

Fix 24637 #9072

Uh oh!

thewilsonator commented Oct 27, 2024

Uh oh!

dlang-bot commented Oct 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Uh oh!

Fix 24637 #9072

Fix 24637 #9072

Uh oh!

Conversation

thewilsonator commented Oct 27, 2024

Uh oh!

dlang-bot commented Oct 27, 2024

Bugzilla references

Testing this PR locally

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants