Skip to content

Conversation

@limepoutine
Copy link
Contributor

This one is massive and messy (and hard to review, evidently). This PR ensures all construction in following forms emplaces directly to the storage, without creating any temporaries, matching C++17 semantics. Besides, this fixes a = b = S(1) being compiled as a blit instead of invoking copy constructor on a.

S s = S(1);
S s = b ? S(1) : S(2);
T t = T(S(1));
this.s = S(1);
return S(1);

What is still missing for a working C++17 std::basic_string binding:

  • copy/move constructors
  • remaining compiler-generated blits
  • druntime hooks
  • inliner

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @limepoutine! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22412"

@thewilsonator
Copy link
Contributor

cc @WalterBright please review as this is alters the backend.

@WalterBright
Copy link
Member

Is it possible to break this into multiple PRs? Such as one per each of the cases you mentioned in the opening comment?

@limepoutine
Copy link
Contributor Author

OK, let me think it a bit...

@WalterBright
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants