Update button interface to support flow triggers #26022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Florian C. Wachmann <[email protected]>
Co-authored-by: Florian C. Wachmann <[email protected]>
Co-authored-by: Florian C. Wachmann <[email protected]>
Co-authored-by: Florian C. Wachmann <[email protected]>
Co-authored-by: Florian C. Wachmann <[email protected]>
Co-authored-by: Florian C. Wachmann <[email protected]>
Co-authored-by: Florian C. Wachmann <[email protected]>
Co-authored-by: Florian C. Wachmann <[email protected]>
Co-authored-by: Florian C. Wachmann <[email protected]>
Co-authored-by: Florian C. Wachmann <[email protected]>
Co-authored-by: Florian C. Wachmann <[email protected]>
Co-authored-by: Florian C. Wachmann <[email protected]>
Co-authored-by: Florian C. Wachmann <[email protected]>
AlexGaillard
commented
Nov 5, 2025
Member
Author
AlexGaillard
left a comment
AlexGaillard
left a comment
There was a problem hiding this comment.
I should still add tests to this, but I had a thought
formfcw
requested changes
Nov 7, 2025
app/src/interfaces/_system/system-flow-select/system-flow-select.vue
Outdated
Show resolved
Hide resolved
…e-to-support-flow-triggers
…e-to-support-flow-triggers
Member
Author
|
@formfcw I've added tests to the best of my ability here. I think let's send this one in so it doesn't drag any longer. |
…e-to-support-flow-triggers
…e-to-support-flow-triggers
formfcw
requested changes
Nov 18, 2025
Contributor
formfcw
left a comment
formfcw
left a comment
There was a problem hiding this comment.
Thank you for fixing the reactivity issue and adding all the tests. The test coverage here is more than enough.
A few more things: one bug, one small improvement, and a few minor details.
app/src/interfaces/_system/system-manual-flow-select/system-manual-flow-select.vue
Outdated
Show resolved
Hide resolved
app/src/interfaces/_system/system-manual-flow-select/system-manual-flow-select.vue
Show resolved
Hide resolved
formfcw
approved these changes
Nov 18, 2025
Contributor
formfcw
left a comment
formfcw
left a comment
There was a problem hiding this comment.
Thank you @AlexGaillard ❤️ This improvement is huge 🚀
LGTM 🎉
AlexGaillard
deleted the
alexgaillard/cms-1338-update-button-interface-to-support-flow-triggers
branch
AlexGaillard
added a commit
that referenced
this pull request
Nov 19, 2025
* Extract flow-sidebar-detail to use-flows composable * Add test cases * Update app/src/composables/use-flows.ts Co-authored-by: Florian C. Wachmann <[email protected]> * Update app/src/composables/use-flows.ts Co-authored-by: Florian C. Wachmann <[email protected]> * Update app/src/composables/use-flows.ts Co-authored-by: Florian C. Wachmann <[email protected]> * Update app/src/composables/use-flows.ts Co-authored-by: Florian C. Wachmann <[email protected]> * Update app/src/composables/use-flows.ts Co-authored-by: Florian C. Wachmann <[email protected]> * Update app/src/composables/use-flows.ts Co-authored-by: Florian C. Wachmann <[email protected]> * Update app/src/composables/use-flows.ts Co-authored-by: Florian C. Wachmann <[email protected]> * Update app/src/composables/use-flows.ts Co-authored-by: Florian C. Wachmann <[email protected]> * Update app/src/composables/use-flows.ts Co-authored-by: Florian C. Wachmann <[email protected]> * Update app/src/composables/use-flows.ts Co-authored-by: Florian C. Wachmann <[email protected]> * Update app/src/composables/use-flows.ts Co-authored-by: Florian C. Wachmann <[email protected]> * Update app/src/composables/use-flows.ts Co-authored-by: Florian C. Wachmann <[email protected]> * Create trigger-flow component to render useFlows button * Make onRefresh required * Refactor for provide/inject pattern * Add logic use-flows to overlay-item * Add functionality to collections and cleanup * More cleanup and simplify * Remove artifact * Major Refactor * Refactor tests to new spec * More cleanup * More refactoring * Update app/src/composables/use-flows.ts Co-authored-by: Florian C. Wachmann <[email protected]> * Move useFlows invocation higher up * Move FlowDialogsContext type and remove .value from props * Replace i18n import and use global import * Adjust jsdoc * Fix weird assertion * Remove unnecessary else * Move styles to correct component * Move useFlows invocation higher and removed unnecessary prop * Amend props for only required refs * Add early return * Disable flow detail for versions * Change unsaved changes CTA * Fix tests * Add missing global template string * Add actionType and toggle field visibility * Add system interface to select flow * Add runManualFlow logic * Cleanup * Remove repeated code * Disable flow in batch mode * Add disable logic * Replace unneeded system interface * Add tweaked system interface back in * Handle case of internal links * Add loading logic * Remove artifact * enhance interface settings with action type display (#26079) * Remove unnecessary options * Change ref to computed * Revert artifact changes * Amend translations * Fix auto import * Change type * Move function invocation higher * Rework rendering and attributes * Rename function and remove redundant manualFlows prop * Rework running flows logic * Hide inactive flows * Standardize use of flow/Flow in translations * Remove unused translation * Add select a flow placeholder * Add manual trigger to assertion * Simplify system interface directive logic and add inactive state * Specify type imports * Replace activeFlows computed with isActiveFlow function * Call runManualFlow directly * Amend icon rendering * Remove unnecessary prop * Add changeset * Rename system interface * Add test coverage * Added missed renames * Add more tests * Fix issue with non-reactive collection prop and add test to catch * Remove undefined string and amend tests * Remove unnecessary code * Remove artifact * Render flow icon and color in flow select interface * Provide default value for shares --------- Co-authored-by: Florian C. Wachmann <[email protected]>
|
Thank you @AlexGaillard !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
presentation-links.vue) has been updated to support triggering flows in addition to internal/external hyperlinksPotential Risks / Drawbacks
Tested Scenarios
Review Notes / Questions
Checklist
Fixes CMS-1487