Skip to content

Conversation

@schneiderstefan
Copy link
Contributor

For subnets that do not set an explicit maximum number of canisters in the registry, this PR changes the behavior from interpreting this from unlimited to a sensible default (120000). When set explicitly, the value can still be set higher or lower.

For subnets that do not set an explicit maximum number of canisters in
the registry, this PR changes the behavior from interpreting this from
unlimited to a sensible default (120000). When set explicitly, the value
can still be set higher or lower.
@github-actions github-actions bot added the chore label Jan 12, 2026
Copy link
Contributor

@derlerd-dfinity derlerd-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

@schneiderstefan schneiderstefan marked this pull request as ready for review January 13, 2026 13:35
@schneiderstefan schneiderstefan requested review from a team as code owners January 13, 2026 13:35
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

Copy link
Contributor

@fspreiss fspreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Protobuf changes LGTM

Copy link
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for Governance owned files (primarily, subnet.proto).

@schneiderstefan schneiderstefan added this pull request to the merge queue Jan 14, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 14, 2026
@schneiderstefan schneiderstefan added this pull request to the merge queue Jan 14, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 14, 2026
@schneiderstefan schneiderstefan added this pull request to the merge queue Jan 14, 2026
Merged via the queue into master with commit 1aa7dba Jan 14, 2026
37 checks passed
@schneiderstefan schneiderstefan deleted the stschnei/default-max-canisters branch January 14, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants