Skip to content

Conversation

@lorenzo-ranciaffi
Copy link
Contributor

@lorenzo-ranciaffi lorenzo-ranciaffi commented Nov 26, 2025

Pull Request Description

Notion
Figma

What does this PR change?

This PR introduces the tipping feature: every creator can set a wallet address in the scene's scene.json file.
Users that crosses the scene (either by navmap or from the minimap) are shown a button that opens a modal to send the tip to the creator.

This feature requires two feature flags:

  1. alfa-donations to enable the feature itself
  2. alfa-recommended-donation-amount which has a main variant that contains an array of decimals (3 values) for the recommended donation amount

Test Instructions

Prerequisites

  • launch the client with the args --dclenv zone --debug --donations-ui

Test Steps

  1. Go to a scene that has the creator's wallet address set (9,49 and eax.dcl.eth work)
  2. You can also select the same scene from the navmap
  3. Open the tip panel
  4. Verify that that:
    1. the scene name is correctly presented
    2. the creator address is correctly presented (it can be a DCL user, in that case you should see the name and profile pic, only the address otherwise)
    3. you can always copy the beneficiary address to the clipboard
    4. you are presented with multiple tipping choices
    5. your current balance is accurately shown
    6. tipping 0 MANA is not allowed (disabled button + error message)
    7. tipping an amount greater than your current balance is not allowed (disabled button + error message)
    8. the amount in MANA you selected is converted in real-time in USD
  5. Pressing Send tip leads you to a new panel that opens the browser
  6. After validating the transaction on the browser, you see a new screen:
    1. if the transaction was successful, after clicking OK on the fancy screen your avatar plays the money emote
    2. if the transaction fails, you are prompted to try again or close the panel
  7. If the tip receiving address is a valid DCL user, they should get an in-game notification about the tip

Additional Testing Notes

  • In order to test the functionality you need to have Amoy MANA on your wallet

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@lorenzo-ranciaffi lorenzo-ranciaffi self-assigned this Nov 26, 2025
@lorenzo-ranciaffi lorenzo-ranciaffi added do not merge shape-up It has been shaped and is awaiting the cycle. labels Nov 26, 2025
@lorenzo-ranciaffi lorenzo-ranciaffi moved this from Todo to In Progress in Explorer Alpha Nov 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

@github-actions
Copy link
Contributor

badge

New build in progress, come back later!

# Conflicts:
#	Explorer/Assets/DCL/PluginSystem/Global/ExplorePanelPlugin.cs
@lorenzo-ranciaffi lorenzo-ranciaffi moved this from Blocked to With QA / Awaiting Review in Explorer Alpha Jan 21, 2026
Copy link
Contributor

@fcolarich fcolarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! left some comments, most are just suggestions, but I think the ProfilePicture ones should be addressed so we can phase out the deprecated Setup method and use the new Bind one

@github-project-automation github-project-automation bot moved this from With QA / Awaiting Review to In Progress in Explorer Alpha Jan 21, 2026
Copy link
Member

@davidejensen davidejensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add other than what @fcolarich already spotted, Nice!!!

@lorenzo-ranciaffi lorenzo-ranciaffi moved this from In Progress to With QA / Awaiting Review in Explorer Alpha Jan 21, 2026
@balducciv
Copy link

balducciv commented Jan 21, 2026

A smoke test of this functionality has passed in both Mac and Windows.
Additionally, the new code implemented for the notifications was tested and passed.

Send Tip

Sender

  • Sender web flow happy path ✅
  • Sender plays money emote ✅

Recipient notification

  • email ✅
  • Synchronic notification ✅
  • Notifications panel ✅

Sender side:

send.tip.-.mac.mp4

Receiver end:

new.tip.received.notification.mp4
email notification receiver notification new tip received

@github-project-automation github-project-automation bot moved this from With QA / Awaiting Review to In Progress in Explorer Alpha Jan 21, 2026
# Conflicts:
#	Explorer/Assets/DCL/Browser/DecentralandUrls/DecentralandUrl.cs
#	Explorer/Assets/DCL/Browser/DecentralandUrls/DecentralandUrlsSource.cs
#	Explorer/Assets/DCL/ExplorePanel/Assets/ExplorePanelUI.prefab
#	Explorer/Assets/DCL/PerformanceAndDiagnostics/Diagnostics/ReportsHandling/ReportCategory.cs
@lorenzo-ranciaffi lorenzo-ranciaffi enabled auto-merge (squash) January 22, 2026 14:14
@lorenzo-ranciaffi lorenzo-ranciaffi merged commit 8fa3722 into dev Jan 22, 2026
9 of 19 checks passed
@lorenzo-ranciaffi lorenzo-ranciaffi deleted the shape/donations branch January 22, 2026 16:28
@github-project-automation github-project-automation bot moved this from In Progress to Done in Explorer Alpha Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shape-up It has been shaped and is awaiting the cycle.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants