-
Notifications
You must be signed in to change notification settings - Fork 14
shape: donations panel #6269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shape: donations panel #6269
Conversation
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
# Conflicts: # Explorer/Assets/DCL/PluginSystem/Global/ExplorePanelPlugin.cs
Explorer/Assets/DCL/Infrastructure/Global/Dynamic/DynamicWorldContainer.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/Notifications/NotificationEntry/FriendsNotificationView.cs
Show resolved
Hide resolved
fcolarich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! left some comments, most are just suggestions, but I think the ProfilePicture ones should be addressed so we can phase out the deprecated Setup method and use the new Bind one
davidejensen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add other than what @fcolarich already spotted, Nice!!!
# Conflicts: # Explorer/Assets/DCL/Browser/DecentralandUrls/DecentralandUrl.cs # Explorer/Assets/DCL/Browser/DecentralandUrls/DecentralandUrlsSource.cs # Explorer/Assets/DCL/ExplorePanel/Assets/ExplorePanelUI.prefab # Explorer/Assets/DCL/PerformanceAndDiagnostics/Diagnostics/ReportsHandling/ReportCategory.cs


Pull Request Description
Notion
Figma
What does this PR change?
This PR introduces the tipping feature: every creator can set a wallet address in the scene's
scene.jsonfile.Users that crosses the scene (either by navmap or from the minimap) are shown a button that opens a modal to send the tip to the creator.
This feature requires two feature flags:
alfa-donationsto enable the feature itselfalfa-recommended-donation-amountwhich has amainvariant that contains an array of decimals (3 values) for the recommended donation amountTest Instructions
Prerequisites
--dclenv zone --debug --donations-uiTest Steps
eax.dcl.ethwork)Send tipleads you to a new panel that opens the browsermoneyemoteAdditional Testing Notes
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.