Increase async cache stale period from 3 to 5 minutes. #608
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 5-minute stale period covers the maximum monthly downtime allowed by a 99.99% uptime SLA (~4.38 minutes). This ensures that even during the worst-case downtime scenario, the cache can continue serving stale tokens while waiting for the auth service to recover (assuming continuous traffic). Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
requested review from
Tejas-Kochar and
parthban-db
and removed request for
parthban-db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Increases the default async cache stale period from 3 minutes to 5 minutes.
Rationale
The 5-minute stale period covers the maximum monthly downtime allowed by a 99.99% uptime SLA (~4.38 minutes). This ensures that even during the worst-case downtime scenario, the cache can continue serving stale tokens while waiting for the auth service to recover (assuming continuous traffic).