Fix line ending related integration failures #4256
Merged
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root cause of TestExport and TestImportDir test failures was that we relied on the backend to normalize line endings. Previously, the backend would normalize line endings during import/export. Starting 2025-12-16, the backend changed to preserve line endings exactly as provided, without any normalization. This change fixes the tests by: 1. Including trailing newlines in input notebook content that we upload (fixes TestExport and TestExportWithFileFlag) 2. Adding integration/.gitattributes to enforce LF line endings on all platforms (Linux, Mac, Windows) for test files (fixes TestImportDir, TestImportDirDoesNotOverwrite, TestImportDirWithOverwriteFlag, TestImportFileFormatAuto, TestImportFileFormatSource) By sending payloads with the expected line endings and ensuring consistent checkout behavior via .gitattributes, the tests now validate correct round-trip behavior across all platforms. Without .gitattributes, Windows would check out test files with CRLF, causing the uploaded content to differ from what Linux/Mac upload, leading to platform-specific test failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
pietern
requested review from
andrewnester,
anton-107,
denik and
shreyas-goenka
as code owners
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
changed the title
denik
approved these changes
Jan 12, 2026
Collaborator
|
Commit: 394953d
30 interesting tests: 18 RECOVERED, 6 KNOWN, 5 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 11c9d86
117 interesting tests: 85 FAIL, 16 KNOWN, 9 RECOVERED, 3 BUG, 2 flaky, 1 SKIP, 1 MISS
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The root cause of TestExport and TestImportDir test failures was that we relied on the backend to normalize line endings. Previously, the backend would normalize line endings during import/export. Starting 2025-12-16, the backend changed to preserve line endings exactly as provided, without any normalization.
This change fixes the tests by:
By sending payloads with the expected line endings and ensuring consistent checkout behavior via .gitattributes, the tests now validate correct round-trip behavior across all platforms.
Without .gitattributes, Windows would check out test files with CRLF, causing the uploaded content to differ from what Linux/Mac upload, leading to platform-specific test failures.
Tests
The mentioned tests should show up as "recovered" in this run.