Skip to content

Conversation

@lklimek
Copy link
Contributor

@lklimek lklimek commented Jan 21, 2026

Issue being fixed or feature implemented

Update dashcore to most recent release (v0.41) - right now we link against some dev version.

What was done?

  • updated dashcore
  • fixed build errors

How Has This Been Tested?

GHA passing

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores

    • Updated platform SDK dependencies to latest compatible versions.
  • Refactor

    • Wallet manager initialization now requires explicit network configuration.
    • Birth height property changed from optional to mandatory for improved data consistency and reliability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

Multiple Cargo.toml files across packages (rs-dapi, rs-dpp, rs-platform-wallet, rs-sdk-ffi) are updated with new git revisions for rust-dashcore dependencies. Additionally, the WalletManager constructor now requires a network parameter, and PlatformWalletInfo's birth_height interface changes from optional to non-optional return values.

Changes

Cohort / File(s) Summary
Dependency revision updates
packages/rs-dapi/Cargo.toml, packages/rs-dpp/Cargo.toml, packages/rs-platform-wallet/Cargo.toml, packages/rs-sdk-ffi/Cargo.toml
Git revision pinned to c0da3509c695351e6dc300723ded35b4f0df16a3 for dashcore-related dependencies (dashcore-rpc, dash-spv, key-wallet, key-wallet-manager, dashcore, dash-spv-ffi) across multiple manifest files. Previous revision: e7792c431c55c0d28efb0344b3a1948f576be5ce
API signature changes
packages/rs-platform-wallet/src/lib.rs
PlatformWalletInfo WalletInfoInterface methods updated: birth_height() return type changed from Option<u32> to u32; set_birth_height() parameter changed from Option<u32> to u32
Example update
packages/rs-platform-wallet/examples/basic_usage.rs
WalletManager constructor call updated from new() to new(network) to match new signature requiring network parameter

Poem

🐰 A hop through the codebase, revisions align,
With birth_height now certain, no longer to pine,
The network's well-fed, dependencies gleam,
Our platform wallet shines—a rust-based dream! ✨

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the main change: bumping dashcore to v0.41.0 with the exact commit hash, directly matching the dependency updates across multiple Cargo.toml files and public API changes in the changeset.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added this to the v3.0.0 milestone Jan 21, 2026
@lklimek lklimek marked this pull request as ready for review January 23, 2026 08:44
@lklimek
Copy link
Contributor Author

lklimek commented Jan 23, 2026

Superseded by #3010

@lklimek lklimek closed this Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants