fixed #616 - report bad macro syntax via OutputList
#617
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is also prevents |
danmar
reviewed
Jan 12, 2026
| macros.insert(std::pair<TokenString,Macro>(macro.name(), macro)); | ||
| try { | ||
| const Macro macro(lhs, rhs, dummy); | ||
| macros.insert(std::pair<TokenString,Macro>(macro.name(), macro)); |
Owner
There was a problem hiding this comment.
Can we use macros.emplace(macro.name(), macro); syntax nowadays or is a newer C++ needed for that?
| macros.insert(std::pair<TokenString,Macro>(macro.name(), macro)); | ||
| } catch (const std::runtime_error& e) { | ||
| if (outputList) { | ||
| simplecpp::Output err = { |
Owner
There was a problem hiding this comment.
I prefer that the = is removed here. We just want that the constructor is called. No initializer list + assignment stuff..
Collaborator
Author
There was a problem hiding this comment.
Will clean up as a whole in a follow-up.
| {}, | ||
| e.what() | ||
| }; | ||
| outputList->push_back(std::move(err)); |
Collaborator
Author
There was a problem hiding this comment.
I only adjusted those when Clang-Tidy told us to.
Will adjust as a whole in a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.