Skip to content

Conversation

@wxtim
Copy link
Member

@wxtim wxtim commented Jan 22, 2026

Fixes #7174

Repro:

[scheduler]
    allow implicit tasks = True
    cycle point format = %Y

[scheduling]
    initial cycle point = 3000
    [[graph]]
        R1 = FOO

[runtime]
    [[FOO]]
    [[foo]]
        inherit = FOO
        execution retry delays = PT10H
        script = exit 1
    [[bar]]
        inherit = FOO
        script = exit 0

Also sets up pre-requisite data for cylc/cylc-ui#2421
Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim changed the base branch from master to 8.6.x January 23, 2026 11:19
@oliver-sanders oliver-sanders added this to the 8.6.3 milestone Jan 23, 2026
@oliver-sanders oliver-sanders added the bug Something is wrong :( label Jan 23, 2026
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@wxtim wxtim force-pushed the 7174.fix.retry-state-bubbling branch from 8dca0de to e042154 Compare January 23, 2026 15:38
@wxtim wxtim requested a review from oliver-sanders January 23, 2026 15:40
Comment on lines 1069 to 1078
# Run the workflow until the creation of the retry xtrigger:
timeout = 0
while (
not schd.pool._get_task_by_id(
'33330101T0000Z/is_retry'
).state.xtriggers
and timeout < 10
):
await asyncio.sleep(1)
timeout += 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not guarantee-able after 1 or 2 main loops?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Well that's over-engineered.

@wxtim wxtim requested a review from MetRonnie January 27, 2026 06:32
…lock and is_xtriggered to cascade up the family states
@wxtim wxtim force-pushed the 7174.fix.retry-state-bubbling branch from bdb3298 to 35ea5bd Compare January 27, 2026 06:34
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Just linkcheck that failed)

@oliver-sanders oliver-sanders merged commit 1410e2c into cylc:8.6.x Jan 28, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is wrong :(

Projects

None yet

Development

Successfully merging this pull request may close these issues.

data store: retry state bubbling not working

3 participants