-
Notifications
You must be signed in to change notification settings - Fork 95
7174.fix.retry state bubbling #7189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7174.fix.retry state bubbling #7189
Conversation
oliver-sanders
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
8dca0de to
e042154
Compare
| # Run the workflow until the creation of the retry xtrigger: | ||
| timeout = 0 | ||
| while ( | ||
| not schd.pool._get_task_by_id( | ||
| '33330101T0000Z/is_retry' | ||
| ).state.xtriggers | ||
| and timeout < 10 | ||
| ): | ||
| await asyncio.sleep(1) | ||
| timeout += 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not guarantee-able after 1 or 2 main loops?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Well that's over-engineered.
…lock and is_xtriggered to cascade up the family states
bdb3298 to
35ea5bd
Compare
MetRonnie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Just linkcheck that failed)
Co-authored-by: Ronnie Dutta <[email protected]>
Fixes #7174
Repro:
Also sets up pre-requisite data for cylc/cylc-ui#2421
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.