wcurl: Really fix CVE-2025-11563 #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we pass a string to is_safe_percent_encode, it always begins with "%'. But the lookup table UNSAFE_PERCENT_ENCODE does not contain "%" so nothing can be matched. Also update the test suite to fix the false positive. Signed-off-by: Xi Ruoyao <[email protected]>
xry111
force-pushed
the
xry111/cve-2025-11563-2
branch
from
8bd1c71 to
65546ba
Compare
7 tasks
Collaborator
|
@xry111 thank you for the report and patch, we had an initial version of our fix which was thoroughly tested and confirmed to work, but then we refactored it later and relied on the unit tests, which was not correctly checking the fix. I'm merging this and creating a new release: |
MingcongBai
pushed a commit
to AOSC-Tracking/curl
that referenced
this pull request
Nov 10, 2025
Link: curl/wcurl#75 Link: curl#19430 Signed-off-by: Mingcong Bai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we pass a string to is_safe_percent_encode, it always begins with "%'. But the lookup table UNSAFE_PERCENT_ENCODE does not contain "%" so nothing can be matched.
Also update the test suite to fix the false positive.