feat(cmath): copysignやsignbitにinfやnanの例を追加 #1559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
⚡ プレビュー (HTML) (更新時刻: 2026-01-12 11:30:48 JST) 変更記事一覧3件の記事が変更されました。 ※ソース (.md) に直接変更のあった記事を列挙しています。グローバル修飾や変換規則の変更による変化は考慮していません。 |
Contributor
Author
|
問題がなければマージしたいと思います。 |
onihusube
reviewed
Jan 11, 2026
akinomyoga
reviewed
Jan 11, 2026
Contributor
Author
|
@onihusube このような形でいかがでしょうか？ |
akinomyoga
reviewed
Jan 12, 2026
Co-Authored-By: Koichi Murase <[email protected]>
teruyamato0731
force-pushed
the
feat/cmath-copysign-signbit
branch
from
fc491d3 to
d3c1b23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
問題点
copysignやsignbitについて、NaNについての挙動が言及されているが、例ではNaNやinfinityなどの値に対して、どのように振る舞うのか示されていなかった。signbitではNaNの符号を検出できる移植性のある方法として、copysignを示していたが、copysignではsignbitに言及されていなかった。加えた変更
copysignの備考にsignbitについての記述を追加しました。copysignの例にinfやnanの例を追加しました。signbitの例にinfやnanの例を追加しました。