Skip to content

Conversation

@hanickadot
Copy link
Contributor

Scripts needs GNU sed, which is not available on macOS by default, but can be easily install with homebrew. If script detects presence of GNU sed, it will create a function to pass attributes from sed command to GNU sed.

I also updated readme.rst accordingly so it mentions homebrew so we don't need to point our users to download packages from internet, but they can just use the package manager.

Also I updated readme.rst and made all links https.

@hanickadot hanickadot force-pushed the checks/gnu-sed-on-mac branch from 4f2f504 to 9f6b237 Compare January 2, 2026 16:53
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good.

@hanickadot hanickadot force-pushed the checks/gnu-sed-on-mac branch from 9f6b237 to 4f1fe9b Compare January 2, 2026 21:55
@jensmaurer
Copy link
Member

@tkoeppe , this looks like an improvement. (The commit message could use an overhaul, mentioning the http -> https change as well. Maybe even in a separate commit.)

@hanickadot hanickadot force-pushed the checks/gnu-sed-on-mac branch 2 times, most recently from c240136 to c6cd247 Compare January 3, 2026 18:53
Using homebrew on macOS
=======================

Instead of downloading packages from the internet, you can use the `HomeBrew package manager <https://brew.sh>` to install all that is needed to build the draft and run checks on it:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "Instead of downloading packages from the internet" referring to? Does brew not download anything from the internet? And is this brew install mactex gnu-sed a complete replacement for the tlmgr installation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brew validates the packages against known checksums. It's against general recommendation "thou shall not download and install stuff random from internet". Brew also manages updating it and also makes easy to uninstall, without depending on package specific way how to remove stuff.

Yes, brew install mactex is a complete replacement for the tlmgr installation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also install BasicTeX using brew and then use tlmgr, but it felt really convoluted and I felt I would end up describing all the combinations. My intention with this PR is just to provide quickest and most straightforwards way how to start with this repo, hence the auto config of gsed instead of asking users to change their whole environment and probably introduce some future problems.

@hanickadot hanickadot force-pushed the checks/gnu-sed-on-mac branch from c6cd247 to 16a793a Compare January 8, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants