Implement StackOverflowError in ParparVM #4372
Draft
+41
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
java.lang.StackOverflowErrorin the ParparVM and updates the native method stack initialization to throw this error instead of crashing with an assertion failure when the stack limit is reached.Key changes:
vm/JavaAPI/src/java/lang/StackOverflowError.java.vm/ByteCodeTranslator/src/nativeMethods.m:java_lang_StackOverflowError.h.initMethodStackto check ifcallStackOffsetreachesCN1_MAX_STACK_CALL_DEPTH - 50.StackOverflowError.StackOverflowErrorconstructor (which uses stack frames) can run successfully.PR created automatically by Jules for task 12895758624426571697 started by @shai-almog