Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This PR implements java.lang.StackOverflowError in the ParparVM and updates the native method stack initialization to throw this error instead of crashing with an assertion failure when the stack limit is reached.

Key changes:

  • Added vm/JavaAPI/src/java/lang/StackOverflowError.java.
  • Modified vm/ByteCodeTranslator/src/nativeMethods.m:
    • Imported java_lang_StackOverflowError.h.
    • Updated initMethodStack to check if callStackOffset reaches CN1_MAX_STACK_CALL_DEPTH - 50.
    • If the limit is reached, it manually pushes the current method to the stack (for accurate stack tracing) and throws StackOverflowError.
    • The buffer of 50 frames ensures the StackOverflowError constructor (which uses stack frames) can run successfully.

PR created automatically by Jules for task 12895758624426571697 started by @shai-almog

Replaced the hard assertion failure in `nativeMethods.m` with a thrown `StackOverflowError` when the recursion limit is reached.
Added a safety buffer of 50 stack frames to allow the exception constructor to execute without triggering infinite recursion.
Added `java.lang.StackOverflowError` to the Java API.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@github-actions
Copy link

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Generated automatically by the PR CI workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant