Add sni rewrite support

[Joey-Rose]

• Read the Contributing document.

Summary

1. Updated routing-api submodule to point to latest commit in joey-add-sni-rewrite-support branch
2. Added sni_rewrite_san field support in route-registrar config and routing-api integration
3. Implemented HAProxy SNI rewrite functionality in TCP router config marshaller using sni str() directive
4. Added unit tests for SNI rewrite functionality in route-registrar, routing-api, and TCP router
5. Updated route registrar job spec to document sni_rewrite_san field
6. Added validation logic in registrar_settings.json.erb template: required when type is sni and terminate_frontend_tls is enabled, cannot be provided when type is sni and terminate_frontend_tls is disabled
7. Updated route registrar usage documentation with sni_rewrite_san field description and example
8. Added comprehensive tests for sni_rewrite_san validation in route_registar_templates_spec.rb covering all validation scenarios

Backward Compatibility

Breaking Change?

No

[ameowlia]

You are also missing...

• Updating the route registrar usage docs
• Updating the route registrar job spec description
• Adding any validations to the job template + tests for that validation

See this PR as an example for all of these items: 129e488

[Joey-Rose]

You are also missing...

• Updating the route registrar usage docs
• Updating the route registrar job spec description
• Adding any validations to the job template + tests for that validation

See this PR as an example for all of these items: 129e488

Just pushed changes to address this feedback. Could you take another look? @ameowlia

[neowulf]

Suggested change

	if server.SniRewriteHostname != "" {
	if enableFrontendTLS && server.SniRewriteHostname != "" {

[Joey-Rose]

just pushed a commit to address this

[ameowlia]

This is making a backwards incompatible change for all users who currently have...

type: sni
terminate_frontend_tls: true. 

...because it is requiring them to include this new property. Is that intended? I thought that the following was supposed to be a valid config?

type: sni
terminate_frontend_tls: true. 
sni_routable_san: meow.com

^ In this case haproxy would keep the sni hostname the same when sending traffic to the backend.

[Joey-Rose]

I talked with @neowulf about this and he said that the field should be required when type: sni and terminate_frontend_tls: true are present. It was completely optional before but I changed it to meet this requirement

[ameowlia]

I also get to template test failures...

Failures:

  1) route_registrar config/registrar_settings.json when type is sni and frontend_tls is enabled and sni_routable_san is provided should use the provided sni_routable_san
     Failure/Error: rendered_hash = JSON.parse(template.render(merged_manifest_properties, consumes: links))

     RuntimeError:
       route_registrar.routes[0].route.sni_rewrite_san must be provided when type is sni and terminate_frontend_tls is enabled
     # (erb):99:in `block in get_binding'
     # (erb):75:in `each'
     # (erb):75:in `each_with_index'
     # (erb):75:in `get_binding'
     # ./spec/route_registar_templates_spec.rb:703:in `block (4 levels) in <top (required)>'

  2) route_registrar config/registrar_settings.json when type is sni and frontend_tls is disabled and sni_rewrite_san is provided raises an error for invalid sni_rewrite_san
     Failure/Error:
       expect { template.render(merged_manifest_properties, consumes: links) }.to raise_error(
         RuntimeError, 'route_registrar.routes[0].route.sni_rewrite_san cannot be provided when type is sni and terminate_frontend_tls is disabled'
       )

       expected RuntimeError with "route_registrar.routes[0].route.sni_rewrite_san cannot be provided when type is sni and terminate_frontend_tls is disabled", got #<RuntimeError: route_registrar.routes[0].route.sni_routable_san cannot be provided when type is sni and terminate_frontend_tls is disabled> with backtrace:
         # (erb):105:in `block in get_binding'
         # (erb):75:in `each'
         # (erb):75:in `each_with_index'
         # (erb):75:in `get_binding'
         # ./spec/route_registar_templates_spec.rb:782:in `block (5 levels) in <top (required)>'
         # ./spec/route_registar_templates_spec.rb:782:in `block (4 levels) in <top (required)>'
     # ./spec/route_registar_templates_spec.rb:782:in `block (4 levels) in <top (required)>'

Finished in 1.17 seconds (files took 0.07684 seconds to load)
368 examples, 2 failures

Failed examples:

rspec ./spec/route_registar_templates_spec.rb:702 # route_registrar config/registrar_settings.json when type is sni and frontend_tls is enabled and sni_routable_san is provided should use the provided sni_routable_san
rspec ./spec/route_registar_templates_spec.rb:781 # route_registrar config/registrar_settings.json when type is sni and frontend_tls is disabled and sni_rewrite_san is provided raises an error for invalid sni_rewrite_san