Umbrella kickoff! #2499
Open
Umbrella kickoff! #2499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for the new Ceph release "umbrella" (version 21.*) across build, test, and CI/CD infrastructure.
- Introduces version 21.* → "umbrella" mapping in build utilities
- Adds "umbrella" to release lists and branch configurations across all CI/CD pipelines
- Configures build targets with noble, jammy, centos9, and windows distributions
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/sync-push | Adds "umbrella" to default releases for sync operations |
| scripts/sign-rpms | Adds "umbrella" to default releases for RPM signing |
| scripts/build_utils.sh | Maps version 21.* to "umbrella" release and updates default release from "tentacle" to "umbrella" |
| quay-pruner/build/delete-tags.py | Adds "umbrella" to protected release tags to prevent deletion |
| ceph-windows-pull-requests/config/definitions/ceph-windows-pull-requests.yml | Whitelists "umbrella" branch for Windows PR builds |
| ceph-volume-nightly/config/definitions/ceph-volume-nightly.yml | Adds "umbrella" branch to nightly ceph-volume test runs |
| ceph-trigger-build/build/Jenkinsfile | Configures build parameters for umbrella branches (centos9, arm64, crimson-debug) |
| ceph-pr-api/config/definitions/ceph-pr-api.yml | Whitelists "umbrella" branch for PR API processing |
| ceph-dev-new-trigger/config/definitions/ceph-dev-new-trigger.yml | Adds umbrella build triggers and excludes umbrella from fallback builds |
| ceph-dev-cron/config/definitions/ceph-dev-cron.yml | Adds umbrella branch polling and cron-based build configuration |
| ceph-dev-build/build/setup_osc | Configures OpenSUSE 15.3 as the distro for umbrella builds |
| ceph-dev-build/build/build_osc | Sets OpenSUSE Leap 15.3 OBS repository for umbrella |
| ceph-dashboard-cephadm-e2e-nightly/config/definitions/ceph-dashboard-cephadm-e2e-nightly.yml | Adds "umbrella" branch to dashboard end-to-end nightly tests |
| ceph-build/config/definitions/ceph-build.yml | Includes "umbrella" in regex pattern for distro-specific build conditions |
| ceph-api-nightly/config/definitions/ceph-api-nightly.yml | Adds "umbrella" branch to API nightly test runs |
| attic/ceph-dev-trigger/config/definitions/ceph-dev-trigger.yml | Adds umbrella branch and build configuration to archived trigger job |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aainscow
reviewed
Dec 9, 2025
aainscow
left a comment
aainscow
left a comment
There was a problem hiding this comment.
LGTM, but I want others to review before we merge.
Author
|
@dmick Looks like I'll need to rebase, but any chance you could review please? |
Signed-off-by: Jamie Pryde <jamiepry@uk.ibm.com>
jamiepryde
force-pushed
the
umbrella-release
branch
2 times, most recently
from
337d8d3 to
46cee8b
Compare
zmc
approved these changes
Jan 12, 2026
Member
zmc
left a comment
zmc
left a comment
There was a problem hiding this comment.
Looks good from my perspective; unsure if others would need or want to weigh in
Author
|
@rzarzynski Hey Radek, do you want to review this before we merge it? |
rzarzynski
reviewed
Jan 20, 2026
Contributor
rzarzynski
left a comment
rzarzynski
left a comment
There was a problem hiding this comment.
Basically LGTM apart a nit mentioned below.
| function release_from_version() { | ||
| local ver=$1 | ||
| case $ver in | ||
| 21.*) |
Contributor
There was a problem hiding this comment.
FWIW ACK on scripts/build_utils.sh.
Contributor
Signed-off-by: Jamie Pryde <jamiepry@uk.ibm.com>
Signed-off-by: Jamie Pryde <jamiepry@uk.ibm.com>
jamiepryde
force-pushed
the
umbrella-release
branch
from
46cee8b to
4ced5e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Umbrella kickoff PR: ceph/ceph#66524