-
-
Notifications
You must be signed in to change notification settings - Fork 764
Fix Frosting --tree output to include tasks connected via IsDependeeOf #4663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Fix Frosting --tree output to include tasks connected via IsDependeeOf #4663
Conversation
|
@Mohammad1384a please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
|
Thanks for looking into this issue! I don't know what the conventions for this project are, but it seems like there are a lot of formatting and style changes here that are otherwise unnecessary making it difficult to see what has actually changed logic wise. Could the styling be kept consistent with what was already there? |
|
@Mohammad1384a thank you for your interest in this project, and also for taking the time to provide this PR. Before we will be able to review this properly, we would require you to make some changes.
Let us know if you have any problems. |
Fix Frosting --tree output so it includes tasks related via IsDependeeOf.
TreeScriptHost previously traversed only task.Dependencies, ignoring relationships encoded via Dependees in the graph.
Updated to use the full graph connections from CakeGraphBuilder, ensuring the printed tree matches the actual dependency graph.