fix: non-regulated preferred units #5794
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-flagly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ludtkemorgan
force-pushed
the
non-regulated-regions
branch
from
47b85d2 to
bf53d28
Compare
ludtkemorgan
changed the title
ludtkemorgan
force-pushed
the
non-regulated-regions
branch
from
bf53d28 to
e72fd9a
Compare
ludtkemorgan
added
the
1 review needed
ludtkemorgan
force-pushed
the
non-regulated-regions
branch
from
e72fd9a to
ee0618c
Compare
| import { screen, within } from "@testing-library/react" | ||
| import { FormProviderWrapper, mockNextRouter, render } from "../../../../testUtils" | ||
| import BuildingDetails from "../../../../../src/components/listings/PaperListingForm/sections/BuildingDetails" | ||
| import { EnumListingListingType } from "@bloom-housing/shared-helpers/src/types/backend-swagger" |
Collaborator
There was a problem hiding this comment.
nitpick (non-blocking): can scoot this import up
| listingSectionQuestions, | ||
| } from "@bloom-housing/shared-helpers" | ||
| import { | ||
| EnumListingListingType, |
Collaborator
There was a problem hiding this comment.
question: Curious why Listing is repeated here
| import ApplicationConductor from "../../../../src/lib/applications/ApplicationConductor" | ||
| import { AppSubmissionContext } from "../../../../src/lib/applications/AppSubmissionContext" | ||
| import { AuthProvider, blankApplication } from "@bloom-housing/shared-helpers" | ||
| import { |
Collaborator
There was a problem hiding this comment.
nitpick (non-blocking): can scoot these imports up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #5380 #5749
Description
This tackles the following issues for non-regulated listings
How Can This Be Tested/Reviewed?
Preferred unit
/household/preferred-unitspage of the form you should see all of the unit types attached to the listing. (Note this page was not appearing previously)regions
Typos
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: