[FIX] Save dialogs: Avoid weird behavior with extensions on macOS #7195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
fix-save-extensions-on-macos
branch
from
d376297 to
d7aadbd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7195 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 335 335
Lines 73978 74074 +96
=======================================
+ Hits 65779 65866 +87
- Misses 8199 8208 +9 🚀 New features to boost your workflow:
|
janezd
commented
Nov 21, 2025
| def initial_start_dir(self): | ||
| if self.filename and os.path.exists(os.path.split(self.filename)[0]): | ||
| return self.filename | ||
| return os.path.splitext(self.filename)[0] |
Contributor
Author
There was a problem hiding this comment.
This change might affect Windows. We need to check and, if necessary, do this only for macOS.
janezd
commented
Nov 21, 2025
| """ | ||
| if self.filename and os.path.exists(os.path.split(self.filename)[0]): | ||
| return self.filename | ||
| return os.path.splitext(self.filename)[0] |
Contributor
Author
There was a problem hiding this comment.
The same change as in the base class. See whether this is OK for Windows, too.
markotoplak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #7156.
On macOS, the native file dialog added a (correct) extension and then complained that, e.g. extension .tab is invalid and that the required extension is .tab. This may be due to changed behavior in Qt6 or macOS Sequoia.
Furthermore, macOS native dialog already asks whether to override the file (the flag
DontConfirmOverwriteis ignored), hence the user was asked twice.Description of changes
This seems to be fixed by
a. keeping the
*in filters andb. by not giving the extension to the initial file name.
Point a won't affect Window because we already had * there. Point 2 can; we need to try and patch if necessary.
I removed the confirmation dialog for macOS, but kept it for Windows.
Includes