Skip to content

Conversation

@tyler-french
Copy link
Contributor

@tyler-french tyler-french commented Jan 23, 2026

Per https://datatracker.ietf.org/doc/html/rfc3986 these docs are actually referring to "scheme" not "schema" of the URI

Copilot AI review requested due to automatic review settings January 23, 2026 21:36
@tyler-french tyler-french requested a review from a team as a code owner January 23, 2026 21:36
@github-actions github-actions bot added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Jan 23, 2026
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 23, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly replaces the term 'schema' with 'scheme' in comments and documentation strings related to URIs, aligning with RFC 3986. The changes are applied consistently across the modified files, improving the accuracy of the documentation. The review found no issues with the proposed changes.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request corrects technical terminology in documentation and comments by replacing "schema" with "scheme" when referring to URI components, in accordance with RFC 3986.

Changes:

  • Updated help text for remote endpoint options (remote_executor, remote_cache, remoteDownloader, remoteOutputService) to use the correct term "scheme"
  • Updated an inline comment in GoogleAuthUtils.java to use "scheme" instead of "schema"

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java Corrected terminology in help text for four remote endpoint options (remoteExecutor, remoteCache, remoteDownloader, remoteOutputService)
src/main/java/com/google/devtools/build/lib/authandtls/GoogleAuthUtils.java Corrected terminology in comment describing URI scheme prefix behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants