Skip to content

Conversation

@3405691582
Copy link
Contributor

Other scripts in bazel do this properly. Not all systems install bash, and they may not be located at /bin.

Other scripts in bazel do this properly. Not all systems install bash,
and they may not be located at /bin.
@github-actions github-actions bot added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Jan 22, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly updates the shebang line in generate_jvm_module_options.sh from #!/bin/bash to #!/usr/bin/env bash. This is a good change that improves the portability of the script by allowing the system to locate the bash interpreter using the user's PATH environment variable, rather than relying on a fixed path. This aligns with best practices for shell scripting across different environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR is awaiting review from an assigned reviewer team-Rules-CPP Issues for C++ rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant