[9.1.0] Avoid materialization of VirtualActionInputs during uploads #28356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using a `Piped{Input,Output}Stream` pair backed by a virtual thread, uploads of `VirtualActionInput` no longer have to materialize the full input in memory and thus require less peak heap.
Closes bazelbuild#28259.
PiperOrigin-RevId: 855713407
Change-Id: I3e382fd4da2fe0f2899d5b00d19d718ddce1a54c
bazel-io
added
the
team-Remote-Exec
bazel-io
added
the
awaiting-review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the issue of high memory usage during VirtualActionInput uploads by refactoring VirtualActionInputBlob to use PipedInputStream and PipedOutputStream backed by virtual threads. The changes to the RemoteCacheClient.Blob interface, removing its Closeable aspect, are consistently applied across Chunker, RemoteExecutionCache, HttpCacheClient, and InMemoryCacheClient. The updated GrpcCacheClientTest now includes a robust test case that directly verifies the memory optimization, which is a significant improvement. Overall, the changes are well-implemented and achieve the stated goal of reducing peak heap memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using a
Piped{Input,Output}Streampair backed by a virtual thread, uploads ofVirtualActionInputno longer have to materialize the full input in memory and thus require less peak heap.Closes #28259.
PiperOrigin-RevId: 855713407
Change-Id: I3e382fd4da2fe0f2899d5b00d19d718ddce1a54c
Commit 92dad2c