-
Notifications
You must be signed in to change notification settings - Fork 857
Integrate Segoe UI Variable #2260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able Fizzy" for consistency
Member
|
@andyra what do you think? |
andyra
requested changes
Jan 7, 2026
Contributor
andyra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small suggestions:
- Rename the file to something like font-face.css
- Use
@layer baseinstead of@layer reset - Add a comment to the CSS file to explain what's going on here—not sure it would be clear unless someone already saw this PR.
andyra
approved these changes
Jan 8, 2026
Contributor
andyra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances font rendering on Windows by adding Segoe UI Variable support with a custom font-face definition to handle weight limitations.
Background
Segoe UI Variable provides superior rendering quality compared to standard Segoe UI. However, it doesn't support font-weight 900, which is used in the application.
Visual Comparison
Before
After
The improved rendering is most noticeable in:
Changes
"Segoe UI Variable Fizzy"font family that:--font-sansin_global.cssto prioritize"Segoe UI Variable Fizzy"before"Segoe UI"This approach allows us to benefit from Segoe UI Variable's improved rendering while maintaining full font-weight support.