Fix creatures not scaling based on LFG information #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oreCreatureSelectLevel This lead to lfg level information not being set when the map is created, and the level scaling logic is not able to find the lfg level information. This commit fixes that by moving the logic from OnCreateMap to a new function called GetMapInfo used in all the places where we need to get the autobalance map info. The first time the map is requested, it will be initialized and the data will be set.
sudlud
reviewed
May 2, 2025
sudlud
reviewed
May 2, 2025
sudlud
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
Level scaling is broken because the OnCreateMap is called after OnBeforeCreatureSelectLevel
This lead to lfg level information not being set when the map is created, and the level scaling logic is not able to find the lfg level information. This commit fixes that by moving the logic from OnCreateMap to a new function called GetMapInfo used in all the places where we need to get the autobalance map info. The first time the map is requested, it will be initialized and the data will be set.
Issues Addressed:
None directly but I think some issues might be linked to the missing information as the MapInfo doesn't store any information about the creatures
SOURCE:
Tests Performed:
Before patch
After patch
How to Test the Changes:
.ab mapstatoutputSkipHigherLevelsandSkipLowerLevelsconfiguration work as expected