Skip to content

Conversation

@sdzh-atlassian
Copy link
Member

What Is This Change?

Small fix to prevent an error in bitbucket logic if the remote URL is too long (the default value is 100 characters)

Error: Input exceeds maximum length. If needed, change the value of parseUrl.MAX_INPUT_LENGTH.

Source of the error: parse-url <- git-up <- git-url-parse

How Has This Been Tested?

See loom:
https://www.loom.com/share/b59e9314d6694d37aaa491d6bb9db546

Basic checks:

  • npm run lint
  • npm run test

@atlassian
Copy link
Contributor

atlassian bot commented Dec 5, 2025

The issue is ready for review, and the acceptance criteria have been met:

  • ✅ Investigate the cause of the plugin crash due to URL length exceeding MAX_INPUT_LENGTH.
  • ✅ Implement a fix to handle long URLs without crashing the plugin.
  • ✅ Consider adjusting the parseUrl.MAX_INPUT_LENGTH or handle the error gracefully.

Check Jira issue

1 similar comment
@atlassian
Copy link
Contributor

atlassian bot commented Dec 5, 2025

The issue is ready for review, and the acceptance criteria have been met:

  • ✅ Investigate the cause of the plugin crash due to URL length exceeding MAX_INPUT_LENGTH.
  • ✅ Implement a fix to handle long URLs without crashing the plugin.
  • ✅ Consider adjusting the parseUrl.MAX_INPUT_LENGTH or handle the error gracefully.

Check Jira issue

@sdzh-atlassian sdzh-atlassian force-pushed the AXON-1640-fix-long-url-parsing branch from e934614 to 93f7093 Compare December 5, 2025 02:53
@sdzh-atlassian sdzh-atlassian force-pushed the AXON-1640-fix-long-url-parsing branch from 93f7093 to 70f012e Compare December 8, 2025 18:30
@sdzh-atlassian sdzh-atlassian force-pushed the AXON-1640-fix-long-url-parsing branch from 70f012e to ab8d7b5 Compare December 8, 2025 18:42
@sdzh-atlassian sdzh-atlassian merged commit 3937c22 into main Dec 8, 2025
13 checks passed
@sdzh-atlassian sdzh-atlassian deleted the AXON-1640-fix-long-url-parsing branch December 8, 2025 19:48
teg-atlassian pushed a commit that referenced this pull request Dec 9, 2025
* [AXON-1640] fix: allow long remote URLs to be parsed
* [AXON-1640] chore: more care around subject_url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants