feat(IntegrationApp): add SceneDelegate support and update Info.plist for scene management in IntegrationApp #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement - Introduced SceneDelegate for better scene lifecycle management in the IntegrationApp. - Updated Info.plist files to include scene configuration and support for multiple scenes. - Cleaned up AppDelegate by removing the window property and adding scene lifecycle methods. - Adjusted project settings and bundle identifiers for consistency.
|
KazuCocoa
reviewed
Nov 23, 2025
| <string/> | ||
| </dict> | ||
| </plist> | ||
| <dict> |
Member
There was a problem hiding this comment.
Could you revert this plist update?
KazuCocoa
reviewed
Nov 23, 2025
| ); | ||
| OTHER_LDFLAGS = ""; | ||
| PRODUCT_BUNDLE_IDENTIFIER = com.facebook.WebDriverAgentLib; | ||
| PRODUCT_BUNDLE_IDENTIFIER = "--com.ahmet.WebDriverAgentRunner"; |
Member
There was a problem hiding this comment.
Please revert these project updates. Only SceneDelegate related changes are expected
KazuCocoa
changed the title
KazuCocoa
reviewed
Nov 23, 2025
|
|
||
| #pragma mark - UISceneSession Lifecycle | ||
|
|
||
| - (UISceneConfiguration *)application:(UIApplication *)application configurationForConnectingSceneSession:(UISceneSession *)connectingSceneSession options:(UISceneConnectionOptions *)options { |
Member
There was a problem hiding this comment.
It looks like UISceneConfiguration, UISceneSession and UISceneConnectionOptions are available since ios 13. Still this project's target iOS is set to 12, so could you apply this for ios 13+ only?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ement