Skip to content

Conversation

@janhoy
Copy link
Contributor

@janhoy janhoy commented Jan 3, 2026

Handle branch name with jira-number only, warn about empty title.

If a user ran this on a branch named SOLR-12345, it would generate a file SOLR-12345.yml with a title "SOLR 12345". Logchange titles shall not include JIRA number, but this happened due to a bad regex. Now it will instead make an empty title, and write a warning to console. If user still forgets to modify title before push, the validate-changelog script will reject it due to empty title.

Handle branch name with jira-number only, warn about empty title
@janhoy janhoy requested a review from dsmiley January 3, 2026 01:52
Copy link
Contributor

@dsmiley dsmiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe out of scope of the change, although the title is open-ended: Can we also please do a "git add" on the file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants