Skip to content

Conversation

@janhoy
Copy link
Contributor

@janhoy janhoy commented Jan 2, 2026

This dependency seems completely unused, could not find explicit usage and saw no change in gradle lock files when removing. If PR tests are green, should be good to go...

I filed this as I was considering #3132 and #3576 for merging...

@github-actions github-actions bot added dependencies Dependency upgrades tool:build labels Jan 2, 2026
@janhoy janhoy requested a review from malliaridis January 3, 2026 00:48
@epugh
Copy link
Contributor

epugh commented Jan 3, 2026

What clued you in that this might not be needed? I often see dependencies with names that I don't recognize and think "I wonder what that does!"!

Copy link
Contributor

@malliaridis malliaridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versionCatalogFormat should remove unused dependencies from version catalog (hence why we also use #keep to keep dependencies we want), and that task is tied on tidy as well. But I don't see unused dependencies being removed. 🤔

What clued you in that this might not be needed?

If you give IntelliJ a few seconds it will gray out the dependency that is not used explicitly. When you then look up the dependency module name in the project, if it does not appear in any gradle lock file, then it is not used at all. That is how I at least find these dependencies that can be removed.

FYI the following two dependencies are also not used:

prometheus-simpleclient = { module = "io.prometheus:simpleclient", version.ref = "prometheus-simpleclient" }
prometheus-simpleclient-httpserver = { module = "io.prometheus:simpleclient_httpserver", version.ref = "prometheus-simpleclient" }

@janhoy
Copy link
Contributor Author

janhoy commented Jan 3, 2026

First I searched for an import and could not find, then I noticed that IntelliJ marked the line grey in Versions TOML file, meaning it is not referenced in any build.gradle file. And not marked as a transitive dep we want to pin either.

May have been in use before removal if Tika perhaps?

@dsmiley
Copy link
Contributor

dsmiley commented Jan 5, 2026

This was for the prometheus exporter, now removed. I take it you folks haven't had the misery of debugging "jq" expressions ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency upgrades tool:build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants