Skip to content

apps/testing: update nvs testcases for struct nvs_ate changed #3310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zhaoxingyu12 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

apps/testing: update nvs testcases for struct nvs_ate changed #3310

zhaoxingyu12 wants to merge 3 commits into from
+234 −172

Conversation

@zhaoxingyu12
Copy link
Contributor

@zhaoxingyu12 zhaoxingyu12 commented Jan 12, 2026

Note: Please adhere to Contributing Guidelines.

Summary

  1. The original test cases were designed based on struct nvs_ate, but now the struct nvs_ate has been changed. The expired field is dynamically adjusted according to the size of the page size, and the test cases also need to be changed accordingly
  2. The special_id of NVS should be changed from fixed ffff to dynamically adjusted based on erase value, and the test cases should also be adjusted accordingly

Impact

testcases for nvs module

Testing

This has been tested and passed in qemu

test_nvs_mount: test begin
test_nvs_mount: success
test_nvs_write: test begin
test_nvs_write: success
test_nvs_corrupt_expire: test begin
test_nvs_corrupt_expire: success
test_nvs_corrupted_write: test begin
test_nvs_corrupted_write: success
test_nvs_gc: test begin
test_nvs_gc: success
test_nvs_gc_3sectors: test begin
test_nvs_gc_3sectors: success
test_nvs_corrupted_sector_close: test begin
test_nvs_corrupted_sector_close: success
test_nvs_full_sector: test begin
test_nvs_full_sector: success
test_nvs_gc_corrupt_close_ate: test begin
test_nvs_gc_corrupt_close_ate: success
test_nvs_gc_corrupt_ate: test begin
test_nvs_gc_corrupt_ate: success
test_nvs_gc_touched_deleted_ate: test begin
test_nvs_gc_touched_deleted_ate: success
test_nvs_gc_touched_expired_ate: test begin
test_nvs_gc_touched_expired_ate: success
test_nvs_gc_not_touched_expired_ate: test begin
test_nvs_gc_not_touched_expired_ate: success

Final memory usage:
VARIABLE BEFORE AFTER DELTA
arena 4294 4294 0
ordblks 1 1 0
mxordblk eb0 eb0 0
uordblks 33e4 33e4 0
fordblks eb0 eb0 0
nsh>

@zhaoxingyu12
apps/testing: nvs testcases support remove align size
87509ab 
mtd/nvs removes CONFIG_MTD_WRITE_ALIGN_SIZE,
testcases need to be modified meanwhile

Signed-off-by: zhaoxingyu1 <[email protected]>
@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Jan 12, 2026

@zhaoxingyu12 please fix typo error:

/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1296: 2st ==> 2nd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1303: 2st ==> 2nd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1310: 2st ==> 2nd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1317: 2st ==> 2nd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1324: 2st ==> 2nd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1333: 3st ==> 3rd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1340: 3st ==> 3rd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1347: 3st ==> 3rd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1354: 3st ==> 3rd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1361: 3st ==> 3rd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:2474: udpate ==> update
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:2579: feild ==> field

@zhaoxingyu12
mtd/nvs: testcases fit the situation where erasestate is 0
84aec70 
Special_id dynamically adjusts based on erase value

Signed-off-by: zhaoxingyu1 <[email protected]>
@jerpelea jerpelea changed the title update nvs testcases for struct nvs_ate changed apps/testing: update nvs testcases for struct nvs_ate changed Jan 12, 2026
jerpelea
jerpelea previously approved these changes Jan 12, 2026
View reviewed changes
@cederom
Copy link
Contributor

cederom commented Jan 12, 2026

TODO: Typos :-)

@zhaoxingyu12 zhaoxingyu12 dismissed stale reviews from jerpelea and xiaoxiang781216 via c83d122 January 12, 2026 17:48
@zhaoxingyu12
mtdconfig/nvs: fix typo error in nvs testcase
28d3f90 
such as: 2st->2nd, 3st->3rd and so on

Signed-off-by: zhaoxingyu1 <[email protected]>
@zhaoxingyu12
Copy link
Contributor Author

zhaoxingyu12 commented Jan 12, 2026

@zhaoxingyu12 please fix typo error:

/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1296: 2st ==> 2nd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1303: 2st ==> 2nd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1310: 2st ==> 2nd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1317: 2st ==> 2nd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1324: 2st ==> 2nd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1333: 3st ==> 3rd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1340: 3st ==> 3rd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1347: 3st ==> 3rd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1354: 3st ==> 3rd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:1361: 3st ==> 3rd
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:2474: udpate ==> update
/home/runner/work/nuttx-apps/nuttx-apps/apps/testing/fs/mtd_config_fs/mtd_config_fs_test_main.c:2579: feild ==> field

done

@zhaoxingyu12
Copy link
Contributor Author

zhaoxingyu12 commented Jan 12, 2026

TODO: Typos :-)

done

@zhaoxingyu12 zhaoxingyu12 requested a review from jerpelea January 13, 2026 06:23
@zhaoxingyu12 zhaoxingyu12 mentioned this pull request Jan 13, 2026
Open
@zhaoxingyu12
Copy link
Contributor Author

zhaoxingyu12 commented Jan 14, 2026

@jerpelea @cederom pls help to review this patch， thanks

cederom
cederom approved these changes Jan 14, 2026
View reviewed changes
Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zhaoxingyu12 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cederom cederom cederom approved these changes

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@jerpelea jerpelea Awaiting requested review from jerpelea

Assignees

No one assigned

Labels

Area: Testing Size: M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhaoxingyu12 @xiaoxiang781216 @cederom @jerpelea