Refactor configuration SystemVMDefaultHypervisor

[GaOrtiga]

Description

The configuration SystemVMDefaultHypervisor is not dynamic, it is necessary to restart the management server after each alteration to its value. Besides, its input is a String, which forces the user to type in the name of the chosen hypervisor, being subject to typos.

This configuration was refactored, allowing its value to be altered in runtime; besides, its input was converted to a select, in order to facilitate the process of choosing the new value.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

How Has This Been Tested?

I changed the values of the configurations and verified that the default hypervisors for new system vms changed accordingly

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9306

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9929)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47242 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8934-t9929-kvm-centos7.zip
Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	300.66	test_events_resource.py
test_01_events_resource	Error	300.67	test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	Failure	92.05	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	Error	1.45	test_network_permissions.py

[BryanMLima]

@blueorangutan package

[blueorangutan]

@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.59%. Comparing base (f958896) to head (29843c8).
⚠️ Report is 494 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/resource/ResourceManagerImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22    #8934      +/-   ##
============================================
+ Coverage     16.57%   17.59%   +1.01%     
- Complexity    13986    15599    +1613     
============================================
  Files          5746     5910     +164     
  Lines        510859   529730   +18871     
  Branches      62140    64718    +2578     
============================================
+ Hits          84696    93216    +8520     
- Misses       416689   426021    +9332     
- Partials       9474    10493    +1019     

Flag	Coverage Δ
uitests	3.57% <ø> (-0.34%)	⬇️
unittests	18.66% <50.00%> (+1.19%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9908

[JoaoJandre]

@blueorangutan package

[blueorangutan]

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10640

[GaOrtiga]

@blueorangutan package

[blueorangutan]

@GaOrtiga a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11102

[DaanHoogland]

@GaOrtiga @BryanMLima what is the status of this PR?
@sureshanaparti @weizhouapache , any concerns to be dealt with?

[GaOrtiga]

@GaOrtiga @BryanMLima what is the status of this PR? @sureshanaparti @weizhouapache , any concerns to be dealt with?

It is ready for review.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11154

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 11158

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[DaanHoogland]

@GaOrtiga ,can you address this comment:
#8934 (comment) , please?

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15395

[DaanHoogland]

@sureshanaparti @weizhouapache are you ok with this as is?

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14896)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49033 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8934-t14896-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

@sureshanaparti @weizhouapache are your concerns met?

[weizhouapache]

code lgtm

[sureshanaparti]

@sureshanaparti @weizhouapache are your concerns met?

looks good, need some testing with multiple hypervisors env.

[GaOrtiga]

@sureshanaparti @weizhouapache are your concerns met?

looks good, need some testing with multiple hypervisors env.

@sureshanaparti I did not test in an env with multiple hypervisors, but I did test changing the value and seeing if the defined hypervisor would be passed during system VM creation (which worked).