-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Usage] Include accounts uuid on the cloud_usage accounts initial saving #12420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12420 +/- ##
=========================================
Coverage 16.23% 16.23%
+ Complexity 13382 13379 -3
=========================================
Files 5657 5657
Lines 498999 499000 +1
Branches 60566 60566
=========================================
+ Hits 81035 81036 +1
- Misses 408928 408929 +1
+ Partials 9036 9035 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16349 |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
vishesh92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
RosiKyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Verified cloud_usage.account table was empty initially
- Confirmed cloud.account table had 4 accounts with valid UUIDs
- Triggered usage job by updating usage.stats.job.exec.time and restarting cloudstack-usage service
- Checked cloud_usage.account table after usage job completed
Test Results:
All UUIDs correctly copied from source to destination.
Source table (cloud.account):
+----+--------------------------+--------------------------------------+
| id | account_name | uuid |
+----+--------------------------+--------------------------------------+
| 1 | system | e41fce8c-f14a-11f0-baeb-1e0015000cb4 |
| 2 | admin | e41ffe26-f14a-11f0-baeb-1e0015000cb4 |
| 3 | baremetal-system-account | a9508fa4-3506-435f-b498-b24f9cad6aa5 |
| 4 | ACSUser | 7c139ee2-6407-416d-af8a-3df8bcca3ec3 |
+----+--------------------------+--------------------------------------+
Destination table (cloud_usage.account) after usage job:
+----+--------------------------+--------------------------------------+
| id | account_name | uuid |
+----+--------------------------+--------------------------------------+
| 1 | system | e41fce8c-f14a-11f0-baeb-1e0015000cb4 |
| 2 | admin | e41ffe26-f14a-11f0-baeb-1e0015000cb4 |
| 3 | baremetal-system-account | a9508fa4-3506-435f-b498-b24f9cad6aa5 |
| 4 | ACSUser | 7c139ee2-6407-416d-af8a-3df8bcca3ec3 |
+----+--------------------------+--------------------------------------+
|
[SF] Trillian Build Failed (tid-15183) |
|
@blueorangutan test |
|
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
Description
This PR adds the uuid value from the cloud accounts into the cloud_usage accounts table as part of the saving of new accounts on the cloud_usage schema.
Fixes: #11077
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?