Error Prone integration - Added error prone to the build #12419

Pearl1594 · 2026-01-13T21:09:15Z

Description

This PR adds error prone to the build. All issues identified by it have been addressed.

Issue were identified at compile time : mvn clean compile -DskipTests

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2026-01-13T21:15:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.03%. Comparing base (6a324da) to head (4d5f819).

❗ There is a different number of reports uploaded between BASE (6a324da) and HEAD (4d5f819). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (6a324da) HEAD (4d5f819)

unittests 1 0

Additional details and impacted files

@@              Coverage Diff              @@
##               4.20   #12419       +/-   ##
=============================================
- Coverage     16.23%    4.03%   -12.21%     
=============================================
  Files          5657      402     -5255     
  Lines        498999    32701   -466298     
  Branches      60566     5826    -54740     
=============================================
- Hits          81035     1319    -79716     
+ Misses       408928    31227   -377701     
+ Partials       9036      155     -8881

Flag	Coverage Δ
uitests	`4.03% <ø> (ø)`
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This PR integrates Google Error Prone into the build system to perform compile-time static analysis. Error Prone has identified and the PR fixes multiple categories of issues including:

Bugs where methods were called but results were ignored
Incorrect primitive comparisons that should use .equals()
Malformed logging statements with wrong placeholders
Dead code and redundant operations
Missing hashCode() implementations when equals() is overridden

Changes:

Added Error Prone (version 2.24.1) to the Maven compiler plugin configuration
Fixed 35+ Error Prone violations across multiple modules including server, engine, plugins, and core components
Applied @SuppressWarnings("BanJNDI") annotations to LDAP-related code where JNDI usage is intentional

Reviewed changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pom.xml	Added Error Prone plugin configuration to Maven compiler
ByteBuffer.java	Fixed missing assignment of Arrays.copyOf result
ServerNtlmsspChallenge.java	Fixed array concatenation in error message
GlobalLoadBalancingRulesServiceImpl.java	Changed == to .equals() for Long comparison
RoutedIpv4ManagerImpl.java	Fixed missing format placeholders in error messages
UserVmManagerImpl.java	Fixed config key retrieval and enum comparison
VolumeApiServiceImpl.java	Removed unnecessary String.format wrapper
ManagementServerImpl.java	Changed == to .equals() for Long comparison
IpAddressManagerImpl.java	Fixed missing throw keyword for exception
HighAvailabilityManagerImpl.java	Fixed logging format with correct placeholders
ConfigurationManagerImpl.java	Changed == to .equals() for Boolean comparison
TemplateJoinDaoImpl.java	Used saturated cast to prevent overflow
Argument.java	Improved Comparable implementation with proper typing
ApiXmlDocWriter.java	Fixed class type checking logic
OpenLdapUserManagerImpl.java	Fixed logging and added JNDI suppression
ADLdapUserManagerImpl.java	Added JNDI suppression annotation
StorPoolDataMotionStrategy.java	Removed unnecessary String.format wrapper
StorPoolPrimaryDataStoreDriver.java	Changed == to .equals() for Long comparison
NexentaStorAppliance.java	Added missing hashCode() implementations
RedfishWrapper.java	Fixed incorrect format placeholder count
XenServerGuru.java	Fixed typo and simplified Pair construction
MultipathSCSIAdapterBase.java	Converted logging to use placeholders
KVMStorageProcessor.java	Fixed missing throw keywords
LibvirtComputingResource.java	Fixed logging format placeholders
HypervInvestigator.java	Simplified boolean return expression
RootCAProvider.java	Removed duplicate method call
OnwireClassRegistry.java	Fixed self-assignment bug
DefaultEndPointSelector.java	Modernized iterator removal pattern
ScaleIOVMSnapshotStrategy.java	Changed == to .equals() for Long comparison
Upgrade41500to41510.java	Replaced anonymous HashMap with Map.of()
DatabaseAccessObject.java	Fixed logging format mismatch
SystemVmTemplateRegistration.java	Replaced anonymous HashMap with Map.of()
NetworkOfferingVO.java	Fixed incorrect hardcoded enum value
NetworkOrchestrator.java	Removed duplicate condition check
VirtualMachineManagerImpl.java	Fixed missing format placeholder
DirectAgentAttache.java	Added missing hashCode() implementation
AgentAttache.java	Added missing hashCode() implementation
DirectDownloadCommand.java	Removed dead assignment
RequestWrapper.java	Fixed incorrect .getClass() call
HAProxyConfigurator.java	Removed unnecessary toString() call
AbstractConfigItemFacade.java	Fixed incorrect .getClass() usage
UpdateBackupOfferingCmd.java	Fixed incomplete error message
MockVmMgr.java	Fixed modulo operation for bounded random

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-13T21:21:52Z

...er-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/OpenLdapUserManagerImpl.java

    }

    @Override
+    @SuppressWarnings("BanJNDI")


The @SuppressWarnings(\"BanJNDI\") annotation is being used to suppress Error Prone warnings about JNDI usage. While JNDI usage in LDAP operations is legitimate, ensure that all JNDI contexts are properly secured and validated to prevent LDAP injection attacks. Review the input validation in these methods (getUsersInGroup, getUserForDn, searchUser, searchUsers) to ensure user-controlled data is properly sanitized before being used in LDAP queries.

Copilot · 2026-01-13T21:21:52Z

...user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java

    private static final String MICROSOFT_AD_MEMBERS_FILTER = "memberOf";

    @Override
+    @SuppressWarnings("BanJNDI")


The @SuppressWarnings(\"BanJNDI\") annotation suppresses JNDI-related warnings. Ensure that the groupName parameter and any other user-controlled inputs are properly validated and sanitized before being used in LDAP queries to prevent LDAP injection vulnerabilities.

Copilot · 2026-01-13T21:21:52Z

...nexenta/src/main/java/org/apache/cloudstack/storage/datastore/util/NexentaStorAppliance.java

+        public int hashCode() {
+            return 1;


The hashCode() implementation for LuParams returns a constant value of 1, which violates the hashCode contract. Since the equals() method considers all instances of LuParams to be equal (line 255), this constant hashCode is technically correct but indicates a potential design issue. If all instances are equal, consider whether this class should be used as a key in hash-based collections, or if the equality logic needs to be refined.

I think we can address this one (@Pearl1594 ?)

engine/orchestration/src/main/java/com/cloud/agent/manager/DirectAgentAttache.java

engine/orchestration/src/main/java/com/cloud/agent/manager/AgentAttache.java

DaanHoogland · 2026-01-14T07:23:46Z

@blueorangutan package

blueorangutan · 2026-01-14T07:26:05Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-14T08:37:16Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16354

Error Prone integration - Added error prone to the build

43162bf

boring-cyborg bot added component:agent component:api component:build component:compute component:hyperv component:kvm component:LDAP component:networking component:orchestration component:primary-storage component:storage component:XenServer labels Jan 13, 2026

Pearl1594 requested review from DaanHoogland, Copilot, sureshanaparti and weizhouapache January 13, 2026 21:10

Copilot started reviewing on behalf of Pearl1594 January 13, 2026 21:11 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Pearl1594 added 7 commits January 13, 2026 16:30

fix tests

ca9fc49

fix copilot comments

0526416

fix codespell check

666105b

fix tests

5967128

fix test identified by errorprone

ff5902c

fix test identified by errorprone

f421499

fix test issues identified by errorprone

4d5f819

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Error Prone integration - Added error prone to the build #12419

Error Prone integration - Added error prone to the build #12419

Pearl1594 commented Jan 13, 2026

Uh oh!

codecov bot commented Jan 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

DaanHoogland Jan 14, 2026

Uh oh!

Uh oh!

Uh oh!

DaanHoogland commented Jan 14, 2026

Uh oh!

blueorangutan commented Jan 14, 2026

Uh oh!

blueorangutan commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Error Prone integration - Added error prone to the build #12419

Are you sure you want to change the base?

Error Prone integration - Added error prone to the build #12419

Conversation

Pearl1594 commented Jan 13, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DaanHoogland commented Jan 14, 2026

Uh oh!

blueorangutan commented Jan 14, 2026

Uh oh!

blueorangutan commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jan 13, 2026 •

edited

Loading