Skip to content

Conversation

@WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Mar 18, 2025

Rationale for this change

This helps simplify the steps to build pyarrow by leveraging Meson, a build system strongly inspired by Python's syntax. In it's current form, it requires Arrow to be installed on the host system, but in the future we may even be able to have PyArrow build Arrow as a subproject, as needed

What changes are included in this PR?

This PR adds Meson configuration files to the Python code base within Arrow.

Are these changes tested?

Yes

Are there any user-facing changes?

We may want to deprecate the traditional setup.py way of building PyArrow alongside this.

@github-actions
Copy link

⚠️ GitHub issue #36411 has been automatically assigned in GitHub to PR creator.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before doing this, include the following code:

# no-op placeholder
arrow_dep = dependency('', required: false)

if get_option('wrap_mode') != 'forcefallback'
  arrow_dep = dependency('arrow', 'Arrow', modules: ['Arrow::arrow_shared'], required: false)
endif

And then shift the rest to look like this:

if not arrow_dep.found()
    cmake = import('cmake')
    # further lookups
    # ...
    arrow_dep = arrow_proj.dependency('arrow_shared')
endif

Copy link

@eli-schwartz eli-schwartz Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this does:

  • check build options for wrap_mode, which is a builtin meson option allowing you to choose whether you wish to resolve bundled dependencies or look for system dependencies. It defaults to finding system dependencies, but when users run meson with --wrap-mode=forcefallback they are asking to explicitly avoid system deps
  • first try to find an arrow dependency, using both names it might be available as:
    • "arrow" (pkgconfig)
    • "Arrow" (cmake, yes capitalization does matter), with modules: ensuring we pick up the correct cmake find_package() variable
  • if it is not available, required: false means we continue to import the cmake subproject as a fallback

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to avoid doing if/else checks:

$ cat subprojects/arrow.wrap

[wrap-file]
directory = arrow
method = cmake

[provide]
arrow = arrow_static_dep

However, using wrap files with method=cmake doesn't (currently) allow you to pass your add_cmake_defines. If you didn't need any defines, then you could simply do this:

arrow_dep = dependency('arrow', 'Arrow', modules: ['Arrow::arrow_shared'])

and you would not need any if/else, it would automatically build the cmake subproject if either:

  • wrap-mode=forcefallback
  • no system arrow was found

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does that wrap file work? The directory to the cpp source is in arrow/cpp whereas the wrap file itself will be located in arrow/python/subprojects - how would that resolve to the right directory?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you included a symlink anyway, I chose not to bother including any mechanism for downloading the wrap contents. Meson skips over that because the directory already exists with the correct content.

The key benefit of the wrap file is that it allows specifying in ini syntax:

  • the subproject should use the method=cmake automatically, when used via dependency()
  • the autogenerated arrow_static_dep (maybe this should be arrow_shared_dep instead?) will fulfill dependency('arrow')

Again, it's missing the necessary cmake defines so it may not be worth pursuing further.

@WillAyd WillAyd force-pushed the use-meson-python branch 2 times, most recently from cf5b610 to b902e1d Compare March 18, 2025 21:50
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Mar 18, 2025
@WillAyd WillAyd force-pushed the use-meson-python branch 6 times, most recently from eabf11f to 7be3f7b Compare March 18, 2025 22:43
Copy link

@eli-schwartz eli-schwartz Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could still use setuptools-scm with meson if you want.

project(
    'pyarrow',
    # ...., 
    version: run_command('python3', '-m', 'setuptools_scm', '--force-write-version-files', check: true).stdout().strip(),
)

@WillAyd WillAyd force-pushed the use-meson-python branch 2 times, most recently from 05ff60d to 6e0a5fe Compare March 19, 2025 03:58
@WillAyd
Copy link
Contributor Author

WillAyd commented Mar 20, 2025

@kou I have made some offline progress on this, but one of the things I am getting stuck on is how the pyarrow C++ modules are being compiled. From what I understand, the current build process will compile Cython modules first (at least lib.pyx) and from that auto-generate lib.h and lib_api.h headers that the pyarrow modules can then reference (?)

Assuming that understanding is correct, where in the process are lib.h and lib_api.h being generated? I found the CMake command that copies them from the source to the build folder, but I can't figure out where they come from in the first place. Any guidance would be appreciated.

@kou
Copy link
Member

kou commented Mar 20, 2025

The following codes may be related:

if(${property_is_api})
set(_generated_files "${output_file}" "${_name}.h" "${_name}_api.h")
elseif(${property_is_public})
set(_generated_files "${output_file}" "${_name}.h")
else()
set(_generated_files "${output_file}")
endif()

set_source_files_properties(pyarrow/lib.pyx PROPERTIES CYTHON_API TRUE)

@WillAyd
Copy link
Contributor Author

WillAyd commented Mar 20, 2025

Ah nevermind I think I have figured it out. So it looks like Cython generates the header files in the build directory when compiling lib.pyx, so the idea is to copy those header files to a directory structure in the build directory that the sources can resolve to.

I'll have to think about the best way to accomplish that via Meson.

@WillAyd WillAyd force-pushed the use-meson-python branch 2 times, most recently from d67b903 to ba8b276 Compare March 20, 2025 18:01
@WillAyd WillAyd force-pushed the use-meson-python branch 6 times, most recently from a2d07ad to 4ff818e Compare March 21, 2025 00:39
@WillAyd WillAyd force-pushed the use-meson-python branch 18 times, most recently from ac463f6 to 960d3c9 Compare December 3, 2025 19:42
@WillAyd WillAyd force-pushed the use-meson-python branch 2 times, most recently from 267040b to 79dc16d Compare December 3, 2025 21:42
# TODO: Renaming lz4 library is a hack - see where the name gets mixed up
run: |
call activate pyarrow-dev
move C:\miniforge\envs\pyarrow-dev\Library\bin\liblz4.dll C:\miniforge\envs\pyarrow-dev\Library\bin\lz4.dll
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a hack to rename these libraries. I'm not sure how the name is getting tripped up on the first place - is this something that would come out of FindLZ4Alt.cmake?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lib prefix for libraries is hardly ever used on Windows AFAIK, how does this happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants