Skip to content

Conversation

@linkun-wang
Copy link
Contributor

@linkun-wang linkun-wang commented Nov 13, 2025

📝 Description

Close #4869 :解决连线vertices工具removeRedundancies设置为false时,mouseup事件无法冒泡到连线的问题

🖼️ Screenshot

Before After
https://github.com/user-attachments/assets/91a9b213-c46b-4f70-a400-0b0355d892cb https://github.com/user-attachments/assets/184defc9-17b5-4541-98b8-f1ab4a6bdd6b

💡 Motivation and Context

🧩 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

🔍 Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.12%. Comparing base (2f46e64) to head (d4411a4).

Files with missing lines Patch % Lines
src/registry/tool/vertices.ts 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4888   +/-   ##
=======================================
  Coverage   82.11%   82.12%           
=======================================
  Files         334      334           
  Lines       38142    38140    -2     
  Branches     7679     7679           
=======================================
  Hits        31321    31321           
+ Misses       6798     6796    -2     
  Partials       23       23           
Flag Coverage Δ
x6 82.12% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/registry/tool/vertices.ts 12.20% <0.00%> (+0.07%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@linkun-wang linkun-wang changed the title fix: 解决连线vertices工具removeRedundancies设置为false时,mouseup事件无法冒泡到连线的问题 fix: 解决连线vertices工具removeRedundancies设置为false时,hisitory失效、mouseup事件无法冒泡到连线的问题,并在examples中增加相应示例 Nov 14, 2025
@linkun-wang linkun-wang marked this pull request as ready for review November 14, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants