Skip to content

Conversation

@SMoraisAnsys
Copy link
Collaborator

Description

As title says, this PR temporary removes the jupyter install target from the all install target.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner January 23, 2026 17:21
@github-actions github-actions bot added the maintenance Package and maintenance related label Jan 23, 2026
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.27%. Comparing base (42ca2af) to head (0d0fe68).
⚠️ Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7138       +/-   ##
===========================================
- Coverage   83.42%   23.27%   -60.15%     
===========================================
  Files         254      253        -1     
  Lines       77735    77655       -80     
===========================================
- Hits        64848    18077    -46771     
- Misses      12887    59578    +46691     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

MaxJPRey
MaxJPRey previously approved these changes Jan 23, 2026
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Out of curiosity, why temporary removal?

@Samuelopez-ansys
Copy link
Member

Hi @SMoraisAnsys , if you delete jupyter from the pyaedt script, the jupyter botton will not work right?

@Samuelopez-ansys Samuelopez-ansys merged commit b3b569c into main Jan 26, 2026
76 of 78 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the chore/temporary-disable-jupyter branch January 26, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extensions maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants