Skip to content

Conversation

@gchaturve
Copy link

@gchaturve gchaturve commented Jan 23, 2026

  • Fixed bug in src/ansys/aedt/core/modules/boundary/common.py for SurfaceGround conductor assignment
  • Added comprehensive test case for SurfaceGround assignment with closed solution type in Q2D
  • Test validates SurfaceGround assignment on modeler regions with various solve options

Fixes #7133

Description

Fixes the missing surface ground assignment workflow in Q2D when using PyAEDT.

Issue linked

Issue number-#7133
While setting up a Q2D Extractor model using PyAEDT, there is no clear or dedicated API method available to assign a surface ground. Unlike manual AEDT workflows, the PyAEDT interface does not clearly expose a function to define a surface as ground for Q2D simulations.
This limitation makes it difficult to programmatically define proper reference conditions in Q2D models, which can affect the correctness and repeatability of capacitance and field extraction results when using PyAEDT.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

- Fixed bug in src/ansys/aedt/core/modules/boundary/common.py for SurfaceGround conductor assignment
- Added comprehensive test case for SurfaceGround assignment with closed solution type in Q2D
- Test validates SurfaceGround assignment on modeler regions with various solve options

Fixes #7133
@gchaturve gchaturve self-assigned this Jan 23, 2026
@gchaturve gchaturve requested a review from a team as a code owner January 23, 2026 07:43
@gchaturve gchaturve linked an issue Jan 23, 2026 that may be closed by this pull request
2 tasks
@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft January 26, 2026 11:50
@nunesanderson
Copy link
Contributor

nunesanderson commented Jan 26, 2026

Hi @gchaturve

Is this PR ready to review?
Do you have pre-commit installed?

@gchaturve
Copy link
Author

Hi @gchaturve

Is this PR ready to review? Do you have pre-commit installed?

Hello @nunesanderson
The PR is ready for review.
I haven’t installed pre-commit yet

@nunesanderson
Copy link
Contributor

Hi @gchaturve
Is this PR ready to review? Do you have pre-commit installed?

Hello @nunesanderson The PR is ready for review. I haven’t installed pre-commit yet

Hi @gchaturve

Could you please install it
image

and update this PR?

@gchaturve
Copy link
Author

Hi @gchaturve
Is this PR ready to review? Do you have pre-commit installed?

Hello @nunesanderson The PR is ready for review. I haven’t installed pre-commit yet

Hi @gchaturve

Could you please install it image

and update this PR?

Yes Thankyou for feedback I will do it and update the PR.

@gchaturve gchaturve marked this pull request as ready for review January 27, 2026 09:59
@gchaturve
Copy link
Author

Hello @nunesanderson I have updated PR and its ready for review.

@nunesanderson
Copy link
Contributor

Hello @nunesanderson I have updated PR and its ready for review.

Hi @gchaturve

It seems that you did not push your commit. The pre-commit is still failing and I don't see a recent commit

image

eblanco-ansys
eblanco-ansys previously approved these changes Jan 30, 2026
@eblanco-ansys eblanco-ansys changed the title Fix: SurfaceGround assignment bug in Q2D boundary module FIX: SurfaceGround assignment bug in Q2D boundary module Jan 30, 2026
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.20%. Comparing base (849172e) to head (a5a81a2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7134       +/-   ##
===========================================
- Coverage   82.28%   19.20%   -63.09%     
===========================================
  Files         254      248        -6     
  Lines       77741    77414      -327     
===========================================
- Hits        63967    14865    -49102     
- Misses      13774    62549    +48775     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in ... Method of assigning surface ground in q2d not available

5 participants