fix: ReferenceError when AWS Router's viewerRequest injection uses await#6332
Open
charliecode wants to merge 1 commit intoanomalyco:devfrom
Open
fix: ReferenceError when AWS Router's viewerRequest injection uses await#6332charliecode wants to merge 1 commit intoanomalyco:devfrom
charliecode wants to merge 1 commit intoanomalyco:devfrom
Conversation
vimtor
approved these changes
Jan 18, 2026
Collaborator
vimtor
left a comment
There was a problem hiding this comment.
thanks for the contribution @charliecode
proof of it working
tested this against the following config:
const api = new sst.aws.Function("MyApi", {
handler: "api.handler",
url: true,
});
const router = new sst.aws.Router("MyRouter", {
routes: {
"/*": api.url,
},
edge: {
viewerRequest: {
injection: `
// Test async injection - triggers issue #6331 if not fixed
const testAwait = await Promise.resolve("test");
`,
},
},
});
return {
router: router.url,
};before
after
Author
Glad to help 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6331
Problem
When using
awaitinedge.viewerRequest.injection, accessingrouterNSinsidegetRoutes()throws aReferenceError: cannot access variable before initializationdue to temporal dead zone (TDZ) issues in the generated CloudFront Function code.Solution
Moved the
routerNSdeclaration inside thegetRoutes()function where it's actually used. This prevents the TDZ issue when the injected code containsawaitstatements.Changes
platform/src/components/aws/router.tsconst routerNS = "${kvNamespace}";from outsidegetRoutes()to inside itTesting
bun run build