Enhancement: Improve default time suggestions for newly created items #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small change which improves the default time suggestions for newly created items (Using the "Record" button), which are then marked "Already Done".
In the case that the current system time is on the currently viewed day in the timeline, we assume the user forgot to hit "Start Now" on a recent event and the default start time is set to one hour prior to now and the default end time is set to now.
In the case that the currently viewed timeline is in the past, we assume the user is filling in an already finished past record and we use the currently viewed time range as the start and end. If this time range is exactly one day, we subtract 5 minutes from the end time so the end falls on the same day as the start.