Skip to content

Conversation

@github-actions
Copy link
Contributor

This PR generated automatically to merge dev with rel-10.1. Please review the changed files before merging to prevent any errors that may occur.

@maliming maliming marked this pull request as ready for review January 30, 2026 07:48
Copilot AI review requested due to automatic review settings January 30, 2026 07:48
@maliming maliming merged commit 6ad2d94 into dev Jan 30, 2026
3 checks passed
@maliming maliming deleted the auto-merge/rel-10-1/4332 branch January 30, 2026 07:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns entity cache configuration with the actual cache item wrapper type and adds tests to verify default and per-cache expiration behavior in the test application.

Changes:

  • Updated AddEntityCache extension methods to configure AbpDistributedCacheOptions based on EntityCacheItemWrapper<T> instead of the underlying entity/cache item type.
  • Adjusted the test application module to register three entity caches with specific absolute expiration times (7, 9, and default 2 minutes).
  • Added test cases and a helper to validate that the default and configured cache entry options (absolute expiration and sliding expiration) are correctly applied for the entity cache wrappers.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
framework/src/Volo.Abp.Ddd.Domain/Volo/Abp/Domain/Entities/Caching/EntityCacheServiceCollectionExtensions.cs Fixes cache configuration to target EntityCacheItemWrapper<...> types, ensuring default/custom DistributedCacheEntryOptions actually apply to the cache used by IEntityCache.
framework/test/Volo.Abp.TestApp/Volo/Abp/TestApp/TestAppModule.cs Configures three entity caches with specific absolute expirations and default options to exercise and validate the new configuration behavior.
framework/test/Volo.Abp.TestApp/Volo/Abp/TestApp/Testing/EntityCache_Tests.cs Adds tests and a reflection-based helper to assert the effective DistributedCacheEntryOptions on IDistributedCache<EntityCacheItemWrapper<...>, Guid> instances, including a new ProductCacheItem2 for default options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants