major error on the fullnode config #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refer to the latest fullnode config, there are p2p-max-nodes-per-host = 100 and max-clients = 100, in this config, the malicious node could use one node to occupy all the incoming connections of the target node to make others unable to connect the node which will be harmful to the network healthy, the correct config may be p2p-max-nodes-per-host = 2 and max-clients = 100
2 tasks
Collaborator
Collaborator
|
Closing: The security fix in this PR has been merged via PR #20, which also includes additional improvements (P2P discovery script and verified peer list). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer to the latest fullnode config, there are p2p-max-nodes-per-host = 100 and max-clients = 100, with this config, the malicious node could occupy all the incoming connections of the target node with one node to make others unable to connect the target node that will be harmful to the network healthy, the correct config may be p2p-max-nodes-per-host = 2