Skip to content

Conversation

@Loori-R
Copy link
Contributor

@Loori-R Loori-R commented Feb 1, 2026

Describe Your Changes

Fixes bar chart rendering at the start of the selected time range.
If the first bar starts before start but ends within the selected range, it is now included and rendered instead of being skipped.

Before
After

Checklist

The following checks are mandatory:


Summary by cubic

Fixes missing first bar in HitsChart when it starts before the selected range but ends within it. This removes gaps at the start of the chart.

  • Bug Fixes
    • Build the x-axis from unique hit timestamps instead of step-based generation to include overlapping bars at the range start.
    • Removed barsCount/useHitsChartConfig/getHitsTimeParams and simplified timestamp logic.
    • Updated changelog with the web UI bugfix.

Written for commit 71d41af. Summary will update on new commits.

@Loori-R Loori-R added the web-ui Issues related to the user interface: layout, styling, usability, or UI-specific bugs. label Feb 1, 2026
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link
Contributor

@arturminchukov arturminchukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@valyala valyala merged commit 92a5a88 into master Feb 3, 2026
1 check passed
@valyala valyala deleted the vmui/hits-chart-first-bar-start-overlap branch February 3, 2026 13:12
@valyala
Copy link
Contributor

valyala commented Feb 3, 2026

@Loori-R , thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web-ui Issues related to the user interface: layout, styling, usability, or UI-specific bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants