Skip to content

Conversation

@Loori-R
Copy link
Contributor

@Loori-R Loori-R commented Feb 1, 2026

Describe Your Changes

Bars with null or undefined values are no longer skipped; instead, they reuse the previous value.

Before
After

Checklist

The following checks are mandatory:


Summary by cubic

Fix cumulative bar chart in the web UI by carrying forward the previous value when a bar is null or undefined. This removes gaps and keeps cumulative growth accurate.

  • Bug Fixes
    • Update cumulativeHits to add v ?? 0 and always push the running sum.
    • Add changelog entry for the web UI cumulative chart fix.

Written for commit 3c97968. Summary will update on new commits.

@Loori-R Loori-R added the web-ui Issues related to the user interface: layout, styling, usability, or UI-specific bugs. label Feb 1, 2026
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link
Contributor

@arturminchukov arturminchukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@valyala valyala merged commit 6f07824 into master Feb 3, 2026
1 check failed
@valyala valyala deleted the vmui/hits-chart-cumulative-null-handling branch February 3, 2026 13:11
@valyala
Copy link
Contributor

valyala commented Feb 3, 2026

@Loori-R , thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web-ui Issues related to the user interface: layout, styling, usability, or UI-specific bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants