[FIX] bantracking: display assigned technician correctly on report #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrated the `data_merge_detail` module from Odoo 16.0 to 18.0 to ensure compatibility with the new version. The following changes were applied: - Updated the module version to `18.0.1.0.0` in the manifest. - Replaced dependencies on `data_merge` with `data_cleaning` to align with the new Odoo structure. - Refactored `ir.cron` records and updated the cron job references to use the `data_cleaning` model for handling data merge operations. - Replaced deprecated `tree` views with `list` views in the UI to comply with the Odoo 18.0 update. - Updated the wizard and view references to reflect changes in the `data_cleaning` module and its views. - Modified `ir_actions.act_window` references to ensure compatibility with the new `list` view mode in Odoo 18.0. These changes ensure the module operates as expected on Odoo 18.0, with no functional changes, just structural updates to match the new version's requirements.
IrvingReyes
force-pushed
the
16.0-cambio-en-custom-report-of-service-irvingreyes
branch
2 times, most recently
from
5febc56 to
6b21e48
Compare
IrvingReyes
force-pushed
the
16.0-cambio-en-custom-report-of-service-irvingreyes
branch
from
6b21e48 to
3999310
Compare
IrvingReyes
force-pushed
the
16.0-cambio-en-custom-report-of-service-irvingreyes
branch
from
3999310 to
cc538d6
Compare
Updated the Service Order report so the technician name and signature always correspond to the technician assigned to the task, instead of the user printing the document. Previously, the report used `env.user.partner_id`, causing the report to wrongly display the name of the user generating the printout. The template now resolves the technician using `doc.user_ids[0].partner_id`, and includes a safety check to avoid errors when no user is assigned to the task. Additionally: - Corrected the label “Technical” to “Technician” and updated its translation accordingly. - Renamed template variables for clarity and consistency. These fixes ensure the printed Service Order accurately reflects the assigned technician, meeting the requirement that official documentation shows the correct responsible person, regardless of who prints the report.
IrvingReyes
force-pushed
the
16.0-cambio-en-custom-report-of-service-irvingreyes
branch
from
cc538d6 to
9cd4807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related MR
Updated the Service Order report so the technician name and signature always correspond to the technician assigned to the task, instead of the user printing the document.
Previously, the report used
env.user.partner_id, causing the report to wrongly display the name of the user generating the printout. The template now resolves the technician usingdoc.user_ids[0].partner_id, and includes a safety check to avoid errors when no user is assigned to the task.Additionally:
These fixes ensure the printed Service Order accurately reflects the assigned technician, meeting the requirement that official documentation shows the correct responsible person, regardless of who prints the report.