feat: adds a standalone transaction-clearer bot for recovering from nonce backlogs. #4915
+293
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
md0x
requested review from
Reinis-FRP,
chrismaree and
mrice32
as code owners
Reinis-FRP
reviewed
Jan 6, 2026
Signed-off-by: Pablo Maldonado <[email protected]>
Reinis-FRP
reviewed
Jan 19, 2026
Comment on lines
23
to
25
| feeBumpNumerator: Number(env.FEE_BUMP_NUMERATOR) || 12, | ||
| feeBumpDenominator: Number(env.FEE_BUMP_DENOMINATOR) || 10, | ||
| replacementAttempts: Number(env.REPLACEMENT_ATTEMPTS) || 3, |
Contributor
There was a problem hiding this comment.
nit: these are named differently in bot-oo
| export const initMonitoringParams = async (env: NodeJS.ProcessEnv): Promise<MonitoringParams> => { | ||
| const base = await initBaseMonitoringParams(env); | ||
|
|
||
| const nonceBacklogConfig: NonceBacklogConfig = { |
Contributor
There was a problem hiding this comment.
bot-oo has some additional parsing checks that would be worth also using here and could reuse parsePositiveInt logic
| return { latestNonce, pendingNonce }; | ||
| } | ||
|
|
||
| export async function clearStuckTransactions( |
Contributor
There was a problem hiding this comment.
might be more maintainable in the future if we have a single tx clearing module here and bot-oo would just reuse it
- Revert bot-oo/index.ts to master (nonce handling moved to transaction-clearer) - Replace feeBumpNumerator/Denominator with simpler feeBumpPercent (default 20%) - Add parsePositiveInt that throws on invalid values instead of silently using defaults Co-Authored-By: Claude Opus 4.5 <[email protected]>
Move clearStuckTransactions and related helpers to bot-utils/transactionClearing.ts so both transaction-clearer and bot-oo can reuse the same logic. Signed-off-by: Pablo Maldonado <[email protected]>
md0x
force-pushed
the
pablo/nonce-backlog-handling
branch
from
828aa01 to
8744689
Compare
md0x
changed the title
Signed-off-by: Pablo Maldonado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a transaction gets stuck (e.g., gas price too low during a spike), it blocks all subsequent transactions from the same wallet. The pending nonce can't advance until the stuck transaction is either mined or replaced.
Solution
transaction-clearer: Standalone bot that clears stuck transactions by submitting 0-value self-transactions at the stuck nonce with escalating gas fees.
Changes
transaction-clearerbotbot-utils/transactionClearing.ts(reusable by other bots if needed)Configuration (env vars)
NONCE_BACKLOG_THRESHOLD- minimum backlog to trigger clearing (default: 1)NONCE_REPLACEMENT_BUMP_PERCENT- fee bump per attempt (default: 20%)NONCE_REPLACEMENT_ATTEMPTS- max attempts per stuck nonce (default: 3)Fixes UMA-3012