Fix: Support explicit jagged array syntax (e.g., new int[][])
#81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…velop Updated Nugets
Previously, the parser could not correctly handle explicit jagged array definitions. It ignored rank specifiers after the type name (e.g., the second `[]` in `int[][]`), causing parsing failures or incorrect type inference.
Changes:
- Added logic to parse optional trailing rank specifiers (consecutive `[]`) in `NewParser`.
- Refactored parsing terms to use `Terms.Char` for starting tokens instead of `XsParser.*` definitions. The `XsParser` definitions include `.ElseError()`, which prevented `ZeroOrMany` and `OneOf` combinators from backtracking or terminating loops correctly (e.g., distinguishing between a new rank `[` and the start of an initializer `{`).
- Updated `ConstructorType.ArrayInit` logic to allow assignment if the explicit jagged array type is compatible with the inferred element type.
- Added unit test `Compile_ShouldSucceed_WithExplicitJaggedArraySyntax` to verify support for `new int[][]`.
remove local comments
Contributor
|
Thank you @HDG520. I appreciate you putting this together. I will have a close look at it tomorrow. |
Contributor
Author
Great! Actually, this is my first time github contribute code on, so maybe some processes are not well executed, please forgive me😂 |
Contributor
Merged to develop. Thank you. I am in the process of restructuring for net10 and adding multi-targeting. We should have this to main sometime this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the parser failed to correctly handle explicit jagged array declarations (e.g.,
new int[][] { ... }).Previously, the parser ignored rank specifiers following the base type definition (e.g., the second
[]inint[][]), which caused syntax exceptions or incorrect type inference.Key Changes:
NewParserto correctly parse optional trailing rank specifiers (consecutive[]).Terms.Char(soft matching) instead ofXsParser.*definitions (hard matching) for starting tokens withinOneOfandZeroOrManyblocks.XsParserdefinitions include.ElseError(), which throws an immediate exception upon mismatch. This prevented the parser from gracefully backtracking or terminating loops (e.g., distinguishing between a new rank[and the start of an initializer{).ConstructorType.ArrayInitto allow assignment if the explicit jagged array type is compatible with the inferred element types.Type of Change
Checklist