Implement the cached_lexsorted_spike_vector. #4315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that replace the _cached_spike_trains
for more information, see https://pre-commit.ci
…e into lexsort_cache # Conflicts: # src/spikeinterface/core/basesorting.py
for more information, see https://pre-commit.ci
…e into lexsort_cache
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Collaborator
|
Can I start building my PR on this one ? @samuelgarcia |
8 tasks
yger
reviewed
Jan 14, 2026
alejoe91
reviewed
Jan 14, 2026
alejoe91
reviewed
Jan 14, 2026
alejoe91
reviewed
Jan 14, 2026
| if propagate_cache and self._cached_spike_trains is not None: | ||
| sorting._cached_spike_trains = self._cached_spike_trains | ||
| if propagate_cache: | ||
| sorting._cached_lexsorted_spike_vector = deepcopy(self._cached_lexsorted_spike_vector) |
Member
Author
There was a problem hiding this comment.
it is an empty dict by default I change it with len() > 0
Member
Author
There was a problem hiding this comment.
I also did more cache propagation now
Co-authored-by: Chris Halcrow <57948917+chrishalcrow@users.noreply.github.com>
for more information, see https://pre-commit.ci
yger
approved these changes
Jan 14, 2026
Member
Author
|
@alejoe91 @chrishalcrow more or less ready on my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea from Pierre Yger:
Implement the
sorting._cached_lexsorted_spike_vectorThis PR also remove the
sorting._cached_spike_trainsbecause it become uselessThe must merged and discussed before #4308
@yger
To be discussed 2 possibilities: