Skip to content

Conversation

@PeterC89
Copy link
Contributor

@PeterC89 PeterC89 commented Jan 6, 2026

About the Contributor

This pull request is posted on behalf of the Sofie TSC.

Type of Contribution

This is a: Documentation improvement

Current Behavior

Docs refer to old repos / NRK ownership

New Behavior

Docs refer to new repos / Governance ownership

Time Frame

Not urgent, but we would like to get this merged into the in-development release.

Status

  • PR is ready to be reviewed.

Documentation Updates for Organizational Changes

This PR (submitted on behalf of the Sofie TSC) updates the Sofie documentation to reflect the transition from NRK-centric framing to Sofie Governance oversight and broader upstream repository references. PR is a documentation improvement, not yet marked ready for review, and requested to be merged into the in-development release (not urgent).

Key Changes

Branding & Ownership Updates

  • About title in about-sofie.md changed from "NRK Sofie TV Automation System" to "Sofie TV Automation System"
  • Removed NRK-only framing; expanded broadcaster examples to include NRK, BBC, and TV 2 Norway
  • Ownership and copyright references updated from NRK to the Sofie Governance organisation in contribution-guidelines.md
  • Governance/maintainer attribution reworded from "The Sofie team at NRK" to "Sofie Governance"
  • Docusaurus tagline updated to emphasize open-source nature and broader organizational support

Repository & Link Updates

  • CasparCG Server links moved from NRK fork (nrkno/sofie-casparcg-server) to upstream (CasparCG/server)
  • Media Scanner links updated from NRK/Sofie forks to official CasparCG/media-scanner
  • Sisyfos Audio Controller attribution updated to Sofie-Automation in libraries.md
  • Removed statement that CasparCG Server was developed/tested against an NRK fork in supported-devices.md
  • Updated various "Further reading" URLs and installer references (including Visual C++ redistributable update from 2015 → 2017)
  • Added CasparCG Server Configuration Validator to additional software references

Process & Contributor Guidance

  • contribution-guidelines.md updated:
  •   Quarterly release cadence introduced
    
  •   Feature freeze six weeks before release; new-feature PRs blocked during freeze
    
  •   PRs to be merged at least three weeks before release for testing
    
  •   RFC process now evaluated by the Sofie Technical Steering Committee (TSC) with a two-week review window; workshops and public notes retained
    
  •   Explicit note that contributions can be refused and maintainers are governed by Sofie Governance
    
  •   Added Tests subsection under Developer Guidelines; cross-references to CONTRIBUTING.md
    

Content & Editorial Improvements

  • Minor clarifications in sync-ingest-changes.md about metaData storage, Piece differentiation (primary, secondary, adlib), and behavior when playStatus is previous
  • Standardized capitalization and terminology (e.g., "Node.js", "JSON logs", "guidelines")
  • Corrected typos and adjusted phrasing across multiple docs for clarity
  • Logging guidance table clarified and examples standardized

Files Modified

  • packages/documentation/docs/about-sofie.md
  • packages/documentation/docs/for-developers/contribution-guidelines.md
  • packages/documentation/docs/for-developers/for-blueprint-developers/sync-ingest-changes.md
  • packages/documentation/docs/for-developers/libraries.md
  • packages/documentation/docs/user-guide/further-reading.md
  • packages/documentation/docs/user-guide/installation/installing-connections-and-additional-hardware/casparcg-server-installation.md
  • packages/documentation/docs/user-guide/supported-devices.md
  • packages/documentation/docusaurus.config.js

Impact

These updates ensure documentation reflects current governance, points to upstream/community repositories, clarifies contributor workflows (including release cadence and RFC/TSC process), and improves clarity for developers and users. Lines changed across docs are small (per-file edits); estimated review effort: medium for larger guideline updates, low for link and wording fixes.

@PeterC89 PeterC89 requested review from a team and Copilot January 6, 2026 21:47
@coderabbitai
Copy link

coderabbitai bot commented Jan 6, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

Documentation updated to remove NRK-specific framing, reflect Sofie Governance ownership, adjust governance and release workflows, and update external links (CasparCG/media-scanner) and minor installation references.

Changes

Cohort / File(s) Summary
Branding & Site Text
packages/documentation/docs/about-sofie.md, packages/documentation/docusaurus.config.js
Removed NRK-specific title/trademark, broadened wording to multiple broadcasters (NRK, BBC, TV 2 Norway) and updated site tagline.
Governance & Contribution Process
packages/documentation/docs/for-developers/contribution-guidelines.md
Replaced NRK ownership with Sofie Governance, updated last-updated stamp, added quarterly release cadence, feature-freeze and merge timelines, and revised RFC/TSC process; added Tests subsection and logging/table wording fixes.
Blueprints / Ingest Guidance
packages/documentation/docs/for-developers/for-blueprint-developers/sync-ingest-changes.md
Clarified metaData phrasing, explicit Piece differentiation (primary, secondary, adlib), and note about modifying most-recent non-adlib PartInstance when playStatus is previous.
External Links & Libraries
packages/documentation/docs/for-developers/libraries.md, packages/documentation/docs/user-guide/further-reading.md, packages/documentation/docs/user-guide/installation/installing-connections-and-additional-hardware/casparcg-server-installation.md, packages/documentation/docs/user-guide/supported-devices.md
Updated CasparCG Server and Media Scanner links from NRK forks to official upstream repos, changed Visual C++ reference to 2017, added CasparCG Server Configuration Validator link, removed mention of Sofie CasparCG fork in supported-devices.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

Suggested reviewers

  • nytamin

Poem

🐰 I hopped through docs with nimble paws,

swapped forks for upstream, redrew the laws.
Governance now minds the garden fair,
links fixed, timelines set with care.
Hooray — the meadow's clearer everywhere!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the primary change across all affected files: updating documentation to reflect organizational changes from NRK-centric to Sofie Governance ownership and repository references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PeterC89 PeterC89 changed the base branch from main to release53 January 6, 2026 21:48
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Julusian
Copy link
Member

Julusian commented Jan 7, 2026

This should probably be directed to the main branch so that the deployed docs are updated before release53 is released

@PeterC89 PeterC89 changed the base branch from release53 to main January 18, 2026 20:22
@PeterC89
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Jan 18, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 7

🤖 Fix all issues with AI agents
In `@packages/documentation/docs/for-developers/contribution-guidelines.md`:
- Line 14: The phrase "open source applications and libraries" should use the
hyphenated compound adjective form; update the sentence in the
contribution-guidelines text (the line starting "The Sofie project includes a
number of open source applications and libraries...") to read "open-source
applications and libraries" so the compound adjective correctly modifies the
noun.
- Line 18: Change the subject-verb agreement in the sentence starting "The Sofie
Governance organisation are responsible..." by replacing "are" with "is" so it
reads "The Sofie Governance organisation is responsible..." (locate that exact
sentence in contribution-guidelines.md and update only the verb).
- Line 108: Change the sentence "When logging, use one of the **log level**
described below:" to use the plural form "log levels" so it reads "When logging,
use one of the **log levels** described below:"; update the phrase in the
contribution-guidelines content where the phrase "When logging, use one of the
**log level** described below:" appears.
- Line 16: The sentence "A list of the "Sofie repositories" [can be found
here](libraries.md).The Sofie Governance organisation owns..." is missing a
space after the period; update the text near the "libraries.md" link (the string
containing "can be found here") to insert a single space between the period and
"The" so it reads "...(libraries.md). The Sofie Governance organisation owns..."
to fix the spacing.
- Line 38: Update the sentence "When a user need is identified and described" to
use the plural form "needs" so it reads "When a user needs are identified and
described" (or better: "When user needs are identified and described"); locate
and change the exact phrase in the contribution-guidelines.md content to correct
the grammar.

In `@packages/documentation/docs/user-guide/further-reading.md`:
- Around line 42-45: The docs currently reference different Visual C++
redistributable versions; determine which VC++ redistributable CasparCG actually
requires (2015 or 2017) and make both mentions consistent: update the text in
further-reading.md (the "Microsoft Visual C++ 2017 Redistributable" link text)
and the CasparCG Server installation guide where it references 2015 so they both
name the confirmed version, and ensure the download URL (vc_redist.x64.exe or
equivalent) points to the correct Microsoft package for that version; search for
other occurrences of "vc_redist" or "Visual C++ 2015/2017" and align those as
well.

In
`@packages/documentation/docs/user-guide/installation/installing-connections-and-additional-hardware/casparcg-server-installation.md`:
- Around line 217-218: Update the Media Scanner Releases link so it points to
the canonical repository; find the markdown line containing the link text "Media
Scanner Releases" and replace the URL
"https://github.com/Sofie-Automation/sofie-media-scanner/releases" with
"https://github.com/CasparCG/media-scanner/releases" so it matches other
references to the CasparCG/media-scanner repo.

Copy link
Member

@nytamin nytamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start!
I'm in favor of merging this asap so we can continue discussions on improvements at the next TSC meeting.

PeterC89 and others added 4 commits January 23, 2026 08:39
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@PeterC89 PeterC89 marked this pull request as ready for review January 23, 2026 08:43
@PeterC89 PeterC89 requested a review from a team as a code owner January 23, 2026 08:43
@PeterC89 PeterC89 merged commit c57f043 into main Jan 23, 2026
63 of 64 checks passed
@PeterC89 PeterC89 deleted the docs/update-docs branch January 23, 2026 08:43
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants