Skip to content

Search universes in Prop_DriverProvidedChaperoneJson_String #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ButterscotchV merged 3 commits into from
Jan 30, 2026
Merged

Search universes in Prop_DriverProvidedChaperoneJson_String #68

ButterscotchV merged 3 commits into from
Jan 30, 2026

Conversation

@ImSapphire
Copy link
Member

@ImSapphire ImSapphire commented Jan 27, 2026

Steam Link stores the chaperone data inside this property.

@ImSapphire ImSapphire mentioned this pull request Jan 28, 2026
Draft
@ImSapphire
Copy link
Member Author

ImSapphire commented Jan 28, 2026

I'm not exactly sure what's going on with CI here, it seems like the tests binary is not being statically linked against libopenvr_api.so...

ButterscotchV
ButterscotchV approved these changes Jan 28, 2026
View reviewed changes
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about the openvr submodule update, but the code itself looks fine. My only suggestion is maybe we can log the universe source when it's found? I don't know if that would be spammy for no reason then, or if it would ever even really be useful. I can envision a situation where a driver reports both the JSON and the path for some reason, where they have differing values... Maybe SteamVR prevents such a case from happening? Regardless, I would be happy with this being merged, assuming the Linux side isn't broken.

@kitlith
Copy link
Member

kitlith commented Jan 28, 2026

Would it be possible to split the padded_string changes into a separate commit from the chaperone search changes?

@ImSapphire ImSapphire force-pushed the sapphire/read-chaperone-json-prop branch from 76b5f82 to 04e3590 Compare January 28, 2026 21:17
@ImSapphire
Copy link
Member Author

ImSapphire commented Jan 28, 2026

Would it be possible to split the padded_string changes into a separate commit from the chaperone search changes?

done

kitlith
kitlith approved these changes Jan 28, 2026
View reviewed changes
Copy link
Member

@kitlith kitlith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ImSapphire ImSapphire force-pushed the sapphire/read-chaperone-json-prop branch from 04e3590 to 8430129 Compare January 28, 2026 22:06
@ImSapphire ImSapphire force-pushed the sapphire/read-chaperone-json-prop branch from 8430129 to 510d965 Compare January 28, 2026 22:50
@ButterscotchV ButterscotchV merged commit f6e8d0c into main Jan 30, 2026
8 checks passed
@ButterscotchV ButterscotchV deleted the sapphire/read-chaperone-json-prop branch January 30, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@kitlith kitlith kitlith approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ImSapphire @kitlith @ButterscotchV