Skip to content

[Tizen.Applications] Modification of critical section logic of lifecycle event processing queue #7369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hyeon-Uk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Tizen.Applications] Modification of critical section logic of lifecycle event processing queue #7369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e701777
Fix the starvation of lifecycle event
Hyeon-Uk Dec 12, 2025
d460a32
Remove retry logic
Hyeon-Uk Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions src/Tizen.Applications.UIGadget/Tizen.Applications/UIGadgetLifecycleManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace Tizen.Applications
internal static class UIGadgetLifecycleManager
{
private static ConcurrentQueue<LifecycleEvent> _lifecycleEvents = new ConcurrentQueue<LifecycleEvent>();
private static bool _processing = false;
private static readonly object _processingLock = new object();

internal static void DispatchLifecycleEvent(IUIGadget gadget, Action action, bool useIdler = true)
{
Expand All @@ -50,31 +50,29 @@ internal static void DispatchLifecycleEvent(IUIGadget gadget, Action action, boo

private static void ProcessLifecycleEvent()
{
if (_processing)
if (!Monitor.TryEnter(_processingLock))
{
Log.Info("Already processing");
return;
}

_processing = true;
var retry = 3;
while (!_lifecycleEvents.IsEmpty)
try
{
if (!_lifecycleEvents.TryDequeue(out LifecycleEvent lifecycleEvent))
while (!_lifecycleEvents.IsEmpty)
{
if ((!_lifecycleEvents.IsEmpty) && (retry-- > 0)) {
Log.Warn("Fail to deque lifecycle events, retry " + retry);
continue;
} else {
if (!_lifecycleEvents.TryDequeue(out LifecycleEvent lifecycleEvent))
{
break;
}
}

var action = lifecycleEvent.Action;
action?.Invoke();
retry = 3;
var action = lifecycleEvent.Action;
action?.Invoke();
}
}
finally
{
Monitor.Exit(_processingLock);
}
_processing = false;
}

internal class LifecycleEvent
Expand Down
Loading